Repository navigation
Port open upstream relinker fixes (#4340, #4802, #4501) - #439
Conversation
Ported from boykopovar/AnyPS5 PR boykopovar#4340 (author @ArjenS-LA), applied as a patch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Ported from boykopovar/AnyPS5 PR boykopovar#4802 (author @ArjenS-LA), applied as a patch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Ported from boykopovar/AnyPS5 PR boykopovar#4501 (author @devavijitsingh), applied as a patch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ck runs before registries are written Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4f846654c1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (firstPath == secondPath) return true; | ||
| if (std::filesystem::exists(first) && std::filesystem::exists(second)) return SameOutputFile(first, second); |
There was a problem hiding this comment.
When one planned output is a dangling symlink to another planned output that does not exist yet, weakly_canonical leaves the symlink unresolved and exists is false for both paths, so this check reports no collision. For example, with output.exe symlinked to the absent windows-diagnostics-imports.txt, diagnostics are written first and the later executable write follows the symlink and silently overwrites them. Account for dangling symlink targets before deciding the destinations are distinct.
Useful? React with 👍 / 👎.
| const auto secondPath = std::filesystem::weakly_canonical(second); | ||
| if (firstPath == secondPath) return true; | ||
| if (std::filesystem::exists(first) && std::filesystem::exists(second)) return SameOutputFile(first, second); | ||
| #ifdef _WIN32 |
There was a problem hiding this comment.
On a case-insensitive POSIX filesystem, such as the default macOS APFS configuration, two nonexistent output paths that differ only by case remain unequal after weakly_canonical, while the case-folding and sensitivity probe are compiled only for Windows. Thus --windows-diagnostics with an executable named WINDOWS-DIAGNOSTICS-IMPORTS.TXT, or case-varied guest registry names, passes this check and later writes both artifacts to the same file. Apply the filesystem-sensitivity check independently of the host OS.
Useful? React with 👍 / 👎.
Brings in the relinker fixes (#436, #439). No conflicts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DgW4n3qYgi5jAAohEmXRQj
Follow-up to #436. Refs #415.
Ported (patches, upstream PRs still open)
Skipped
Tests
-DANYPS5_RELINKER_ONLY=ON -DCMAKE_OSX_ARCHITECTURES=x86_64, full build + ctest: 116/116 passed (includes guest_gnu_hash, output_collisions, guest_module_directories).-DANYPS5_ROSETTA_LIBS=ON, x86_64): rosetta_cpuid_tests builds and passes. No new codegen sources, so tools/rosetta/tests/CMakeLists.txt is unchanged.🤖 Generated with Claude Code