-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Updated readme and makefile so its easier for newbies to get ipv6 adresses #21500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ses for this example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, welcome, and thanks for taking the time to enhance RIOT. First PR and it's a round number :-)
A few comments inline.
#DEFAULT_CHANNEL ?= x | ||
|
||
#include $(RIOTMAKE)/default-radio-settings.inc.mk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#DEFAULT_CHANNEL ?= x | |
#include $(RIOTMAKE)/default-radio-settings.inc.mk | |
# Set a custom channel if needed | |
include $(RIOTMAKE)/default-radio-settings.inc.mk |
No need to comment that out: many other examples have that at the end active, I just never ran this example in a situation where it was needed. They all prefix it with this line, and none of them actually set a diverging channel. (So either a user is aware how they can change the DEFAULT_CHANNEL, or none of the peers diverge from the default anyway).
@@ -51,6 +51,9 @@ Once that is ready, in a parallel shell, run: | |||
``` | |||
$ aiocoap-client 'coap://[2a02:0b18:c13b:8018:1234:56ff:fe78:90ab]/.well-known/core' | |||
``` | |||
Note if you want to work with global addresses after flushing the example on a board, run the boarder router example in examples/networking/gnrc/gnrc_border_router please use the channel used there and replace the x in this line of the makefile: DEFAULT_CHANNEL ?= x with the channel used by the boarder router. If unsure you can always execute the boarder router and type in ifconfig to get the channel. Please comment out #DEFAULT_CHANNEL ?= x (The x should now be an actual number ) and comment out this line: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tip strongly depends on the radio technology -- other boards have WiFi and need credentials, or they have USB Ethernet or are native (and then they don't need config but instead need the user's network manager to pick them up and forward the Internet to them).
This is handled inconsistently across the examples, but at least this should reflect that for running on an 802.15.4 board, then those setups are necessary. Maybe it can refer to a general network section documentation? (@AnnsAnns, you're working on the guides, is anything brewing there that could be linked as a general "this example uses the network, but there are many supported types, pick yours from this guide to get an address"?)
I updated the Makefile so that you can get ipv6 addresses for this example from the boarder router. I explained this in an additional note that I included in the read me