-
Notifications
You must be signed in to change notification settings - Fork 4
docs edited #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs edited #29
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,3 +2,4 @@ | |
| frontend/package-lock.json | ||
| frontend/node_modules | ||
| backend/node_modules | ||
| .DS_Store | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,6 @@ | ||
| import React from 'react'; | ||
| import DocumentationContent from '@/components/docs/DocumentationContent'; | ||
| import DocsPageTemplate from '@/components/docs/DocsPageTemplate'; | ||
|
|
||
| export default function DocumentationPage() { | ||
| return ( | ||
| <div className="w-full h-full flex flex-col items-center"> | ||
| <DocumentationContent /> | ||
| </div> | ||
| ); | ||
| return <DocsPageTemplate />; | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,11 +11,8 @@ export default function DocsLayout({ | |
| return ( | ||
| <div className="min-h-screen bg-background text-foreground flex flex-col"> | ||
| <Navbar /> | ||
| <div className="flex-1 max-w-7xl mx-auto w-full px-4 sm:px-6 lg:px-8 flex items-start gap-12"> | ||
| <Sidebar /> | ||
| <main className="flex-1 py-12 lg:py-16 min-w-0"> | ||
| <div className="flex-1 max-w-7xl mx-auto w-full px-4 sm:px-6 lg:px-8 py-8 flex flex-col"> | ||
| {children} | ||
| </main> | ||
| </div> | ||
|
Comment on lines
13
to
16
|
||
| <SearchModal /> | ||
| </div> | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,6 @@ | ||
| import React from 'react'; | ||
| import DocumentationContent from '@/components/docs/DocumentationContent'; | ||
| import Link from 'next/link'; | ||
| import DocsPageTemplate from '@/components/docs/DocsPageTemplate'; | ||
|
|
||
| export default function DocsPage() { | ||
| return ( | ||
| <div className="min-h-screen bg-background flex flex-col"> | ||
| <main className="flex-1 w-full max-w-4xl mx-auto py-12 px-6"> | ||
| <DocumentationContent /> | ||
| </main> | ||
| </div> | ||
| ); | ||
| return <DocsPageTemplate />; | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| import React from 'react'; | ||
| import { Sidebar } from '@/components/docs/Sidebar'; | ||
| import DocumentationContent from '@/components/docs/DocumentationContent'; | ||
|
|
||
| export default function DocsPageTemplate() { | ||
| return ( | ||
| <div className="flex flex-col lg:flex-row items-start gap-12 w-full pt-4"> | ||
| <Sidebar /> | ||
| <div className="flex-1 min-w-0 w-full mb-16"> | ||
| <DocumentationContent /> | ||
| </div> | ||
| </div> | ||
| ); | ||
| } |
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -6,6 +6,7 @@ import Link from 'next/link'; | |||||||||||||||||||||
| const docLinks = [ | ||||||||||||||||||||||
| { name: 'Introduction', href: '/docs#introduction', id: 'introduction' }, | ||||||||||||||||||||||
| { name: 'Architecture', href: '/docs#architecture', id: 'architecture' }, | ||||||||||||||||||||||
| { name: 'Execution Lifecycle', href: '/docs#execution-lifecycle', id: 'execution-lifecycle' }, | ||||||||||||||||||||||
| { name: 'Quick Start', href: '/docs#quick-start', id: 'quick-start' }, | ||||||||||||||||||||||
|
||||||||||||||||||||||
| { name: 'Quick Start', href: '/docs#quick-start', id: 'quick-start' }, | |
| { name: 'Integration & API Flow', href: '/docs#quick-start', id: 'quick-start' }, |
Copilot
AI
Apr 13, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sidebar is now reused on both /docs and /dashboard/docs via DocsPageTemplate, but the link hrefs are hard-coded to the /docs#... route. While the click handler prevents navigation, copying/opening links (or non-JS navigation) will take users out of the dashboard. Consider switching to hash-only hrefs (e.g., #introduction) or making the base path configurable.
| { name: 'Introduction', href: '/docs#introduction', id: 'introduction' }, | |
| { name: 'Architecture', href: '/docs#architecture', id: 'architecture' }, | |
| { name: 'Execution Lifecycle', href: '/docs#execution-lifecycle', id: 'execution-lifecycle' }, | |
| { name: 'Quick Start', href: '/docs#quick-start', id: 'quick-start' }, | |
| { name: 'Introduction', href: '#introduction', id: 'introduction' }, | |
| { name: 'Architecture', href: '#architecture', id: 'architecture' }, | |
| { name: 'Execution Lifecycle', href: '#execution-lifecycle', id: 'execution-lifecycle' }, | |
| { name: 'Quick Start', href: '#quick-start', id: 'quick-start' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
classNamestring contains duplicated/contradictory utilities (e.g.,justify-centerappears twice, and bothhover:border-primary/50andgroup-hover:border-primary/50are present). Cleaning these up will make the styling easier to reason about and reduce accidental regressions.