Skip to content

Cmt dev 893 fix resource rte bugs#910

Merged
Scapsters merged 18 commits intocmt-devfrom
cmt-dev-893-fix-resource-rte-bugs
Apr 14, 2026
Merged

Cmt dev 893 fix resource rte bugs#910
Scapsters merged 18 commits intocmt-devfrom
cmt-dev-893-fix-resource-rte-bugs

Conversation

@Scapsters
Copy link
Copy Markdown

this PR looks way better commit-by-commit

francisjgrant
francisjgrant previously approved these changes Mar 24, 2026
@AydenDaz
Copy link
Copy Markdown

  • When adding a link in the title through the display text, the content/body is disabled which is expected. However clicking back into the title box after adding this link and adding normal text makes the content/body editable again.
  • Not a new glitch but header 1 is bolded in the RTE but not when displaying. Not sure why this happens though
  • Warning that body is not editable does not appear when a link exists and in edit mode
  • The text color button often gets highlighted even when there's no actual colors besides the standard black involved
  • With a title, if there's a highlight with color AND other text that's either colored or highlighted (see pictures) an error is returned that says 'can't access property "sessionNum", data is undefined'. This also happens during editing although no error is shown and nothing is updated.
image image
  • In the title, when highlighting text and putting in a link without display text changes it to an anchor tag, but when submitting gives the 'can't access property "sessionNum", data is undefined' error. It also has the same editing problem as before.
  • Unlinking removes colors from normal text except for the special SE color (that color remains the same, but any other color is turned to black). Highlights still remain
  • Adding a link and resource with display text does not actually add the link and the text is treated as normal text. Any text added in the same line however IS treated as the link
  • When directly pasting a link using ctrl + v or "paste" in the title, the 'can't access property "sessionNum", data is undefined' error appears. Unlinking does not help either in this scenario and still causes the error
  • Unlink is tied to body color for some reason, when you click unlink it highlights the text color button
  • Clicking on an empty box displays the error: 'can't access property "id", sessionData.find(...) is undefined'
  • When unlinking a resource when editing the warning about the body being disabled disappears but the body is still disabled
  • When highlighting text and uploading a resource in the title, it SOMETIMES gives the 'can't access property "sessionNum", data is undefined' error, but it doesn't happen all the time?? I'm not sure what the criteria is for it to happen
  • Having any special css (bold, underline, italics, headers) with color and highlights at the same time (issue from before) as well as having a line with CSS and only text color and a line with CSS and only highlights results in the 'can't access property "sessionNum", data is undefined' error (see picture)
image
  • For the title, when having normal text on one line, colored text on another, and highlighted text on another, when the highlight and color are both selected regardless of the line, it SOMETIMES returns the 'can't access property "sessionNum", data is undefined' error (I genuinely do not know why it happens only sometimes, when testing it wasn't working but suddenly did... I don't know the exact criteria. See picture)
image
  • Ordered and unordered lists do not appear in titles in the page
  • The max-height doesn't work in the body, leading to need to scroll up and down to get to the CSS buttons
  • Copying and pasting doesn't add all the CSS elements from the page (e.g. from the SWEN261 page but I don't know how I did it before)

@AydenDaz
Copy link
Copy Markdown

AydenDaz commented Apr 9, 2026

Most bugs got fixed by editing the title in the schema

Anyways remaining bugs/oddities that should be investigated:

  1. Not a new glitch but header 1 is bolded in the RTE but not when displaying. Not sure why this happens though. Similar thing with styling for h2 and h3 dropdowns. If I had to guess, something with prose or one of the many CSS files isn't working correctly.
  2. Adding a link and resource with display text does not actually add the link and the text is treated as normal text. Any text added in the same line however IS treated as the link
  3. when adding a link without display text and without overriding any text, it appears as black text and isn't underlined until pressing space. This also causes a the content editor disabled warning not to appear when editing if you haven't pressed space, but it still being disabled.
  4. Sometimes when deleting links/resources in the title (through selection or just hold down delete), does not re-enable body and any added text becomes that previously deleted link/resource until pressing enter
  5. Copying and pasting doesn't add all the CSS elements from the page (e.g. from the SWEN261 page but I don't know how I did it before)

I think the main bugs that kinda need to be fixed are 2 and 4, with a maybe on 3. The others are more User experience and aren't critical if they would take a long time to fix.

@AydenDaz AydenDaz marked this pull request as draft April 13, 2026 14:02
@AydenDaz AydenDaz linked an issue Apr 13, 2026 that may be closed by this pull request
@AydenDaz AydenDaz marked this pull request as ready for review April 13, 2026 22:11
@AydenDaz AydenDaz requested a review from francisjgrant April 13, 2026 22:12
@AydenDaz AydenDaz dismissed francisjgrant’s stale review April 13, 2026 22:12

Approval was outdated, more fixes now.

@Scapsters Scapsters merged commit 535cdaa into cmt-dev Apr 14, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug/Enhancement: Fix slow times for sessions

3 participants