-
Notifications
You must be signed in to change notification settings - Fork 268
Find Mode TrustVerify #3604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Find Mode TrustVerify #3604
Changes from 9 commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
097f485
add find mode TrustVerify, first draft
cderb 12c9b0f
fix build errors
cderb d8990b5
Merge remote-tracking branch 'pub/develop' into cderb/find_mode_verify
cderb c0a9d9c
tune when trustverify and performance check fails, add logging statem…
cderb 4721681
add api test for new find mode
cderb 881465c
stop addition of results when trustverify has regenerated, debug prints
cderb ccffe8a
fetch max workspace for trustverify
cderb 5d551ad
remove log
cderb eeda496
trustverify triggers tuning on miss
cderb 12c1cff
Merge branch 'develop' into cderb/find_mode_verify
cderb 4234f4c
clang format
cderb eaba243
clang format
cderb b47bc73
update documentation for TrustVerify
cderb 759ac80
Apply suggestions from code review
cderb a58f556
hip tidy
cderb ed89db5
Merge branch 'develop' into cderb/find_mode_verify
cderb 2bb47c7
reduce fdb loads
cderb 6fbb59d
split out logic for fdb verification to new function. Allow verificat…
cderb b945bcd
cleanup
cderb 83b351a
add FallbackPath enum to pass fallback option selection
cderb e6e8beb
add time constraints around TrustVerify tuning, add TrustVerifyFull f…
cderb 0e927ed
update test
cderb 3009a13
clang-format
cderb 1b7102f
hip tidy
cderb 1c66b4c
update doc
cderb c87eaf1
fix bug in registering evaluated solvers
cderb d187884
clang format
cderb 46574eb
Merge branch 'develop' into cderb/find_mode_verify
cderb 0a1b00e
Merge branch 'develop' into cderb/find_mode_verify
cderb 3971bcd
Merge branch 'develop' into cderb/find_mode_verify
cderb 9b3aa07
Merge remote-tracking branch 'origin/develop' into cderb/find_mode_ve…
cderb ce2c614
merge fix for queue handling of last_imprv
cderb 7730b55
add env for verify tolerance, bugfix for evaluating solutions.
cderb 768cc1f
Merge remote-tracking branch 'origin/develop' into cderb/find_mode_ve…
cderb 88ac81c
re-organize code to prevent IsEnoughWorkspace print for hybrid_dynami…
cderb 95f4841
clang format
cderb 9aa345e
revert to hybrid dynamic from trust verify when user db disabled
cderb aebb7ff
add assert for solver order in VerifiedFDBSolution
cderb cfda2ef
clang format
cderb 229bd55
hip tidy
cderb 6c3c074
Merge branch 'develop' into cderb/find_mode_verify
cderb 727c0ce
break out smaller functions
cderb d6109ee
more function splitting
cderb 7020591
drafting ut for new find mode
cderb e2b4998
test updates
cderb 5d2fbb2
set test values
cderb 5e8012a
cleanup
cderb 5a9b6fb
Merge remote-tracking branch 'origin/develop' into cderb/trustverify_ut
cderb e993398
conform to gtest naming
cderb aa3894e
Merge branch 'cderb/trustverify_ut' of https://github.com/ROCm/MIOpen…
cderb 0ca672d
tidy
cderb 4bb57ad
replace memset with fill_n for tidy
cderb a03d847
Merge branch 'develop' into cderb/find_mode_verify
cderb aa9e7d2
Merge branch 'develop' into cderb/find_mode_verify
cderb 2beb2bb
Merge branch 'develop' into cderb/find_mode_verify
cderb e7b6e77
revert default find mode to dynamic hybrid
cderb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -664,6 +664,8 @@ typedef enum | |
miss, uses the existing Find machinery with skipping non-dynamic kernels, thus saving | ||
compilation time. Faster start-up times than Hybrid Find, but GPU performance might be | ||
a bit worse. >*/ | ||
miopenConvolutionFindModeTrustVerify = | ||
6, | ||
miopenConvolutionFindModeDefault = | ||
miopenConvolutionFindModeDynamicHybrid /*!< Default FindMode >*/ | ||
Comment on lines
670
to
671
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Resetting default mode to dynamic hybrid. |
||
} miopenConvolutionFindMode_t; | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs docs like the others.
The PR description is probably pretty close to what is needed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added doc