Skip to content

third-party/host-blas: upgrade for GCC 15 fix#1433

Merged
marbre merged 1 commit into
ROCm:mainfrom
scottt:scottt-gcc15-openblas
Sep 12, 2025
Merged

third-party/host-blas: upgrade for GCC 15 fix#1433
marbre merged 1 commit into
ROCm:mainfrom
scottt:scottt-gcc15-openblas

Conversation

@scottt

@scottt scottt commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

Upgrade OpenBLAS version from 0.3.29 to 0.3.30 to fix build on GCC 15.

The critical fix is:
OpenMathLib/OpenBLAS#5258
to fix the following build errors:

/home/schenker/workspace/OpenBLAS/lapack-netlib/SRC/sgees.c:720:27: error: too many arguments to function ‘select’; expected 0, have 2
 720 |       bwork[i__] = (*select)(&wr[i__], &wi[i__]);
     |                    ~^~~~~~~~ ~~~~~~~~
/home/schenker/workspace/OpenBLAS/lapack-netlib/SRC/sgeesx.c:815:27: error: too many arguments to function ‘select’; expected 0, have 2
 815 |       bwork[i__] = (*select)(&wr[i__], &wi[i__]);
     |                    ~^~~~~~~~ ~~~~~~~~
/home/schenker/workspace/OpenBLAS/lapack-netlib/SRC/sgees.c:836:22: error: too many arguments to function ‘select’; expected 0, have 2
 836 |       cursl = (*select)(&wr[i__], &wi[i__]);
     |               ~^~~~~~~~ ~~~~~~~~
/home/schenker/workspace/OpenBLAS/lapack-netlib/SRC/sgeesx.c:953:22: error: too many arguments to function ‘select’; expected 0, have 2
 953 |       cursl = (*select)(&wr[i__], &wi[i__]);
     |               ~^~~~~~~~ ~~~~~~~~

@marbre

marbre commented Sep 9, 2025

Copy link
Copy Markdown
Member

Let me update the tarball in the S3 bucket.

@scottt

scottt commented Sep 10, 2025

Copy link
Copy Markdown
Contributor Author

Let me update the tarball in the S3 bucket.

Hi @marbre , I'll update the patch with the S3 bucket URL for OpenBLAS-0.3.30.tar.gz after you had a chance to upload it.

@marbre marbre left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uploaded the tarball to S3. Checksum should be unchanged.

Comment thread third-party/host-blas/CMakeLists.txt Outdated
Upgrade OpenBLAS version from 0.3.29 to 0.3.30 to fix
build on GCC 15.

The critical fix is:
OpenMathLib/OpenBLAS#5258
@scottt scottt force-pushed the scottt-gcc15-openblas branch from e442dc8 to a8f96a6 Compare September 11, 2025 23:45
@scottt

scottt commented Sep 11, 2025

Copy link
Copy Markdown
Contributor Author

@marbre , I've:

  1. Verified the OpenBLAS-0.3.30.tar.gz in the S3 bucket has the same checksum
  2. Changed the tarball URL in the patch to point to rocm-third-party S3
  3. Rebased the patch

@marbre

marbre commented Sep 12, 2025

Copy link
Copy Markdown
Member

Test failurs look unrelated. I re-triggered the hipBLASLt tests though but we can go ahead with landing this.

@scottt

scottt commented Sep 12, 2025

Copy link
Copy Markdown
Contributor Author

@marbre , could you do the honors of landing this. I still need one review approval and I think I lack the permission to do the final merge.

@marbre marbre left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests timed out but this is unrelated to the patch.

@marbre marbre merged commit e6bebfe into ROCm:main Sep 12, 2025
71 of 77 checks passed
@github-project-automation github-project-automation Bot moved this from TODO to Done in TheRock Triage Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants