-
Notifications
You must be signed in to change notification settings - Fork 277
Use configure_pytorch_release_matrix.py to drive the CI job matrix #6082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
9db3d21
a925161
5b77b92
403b4b9
8c549ca
011d84b
2bed74e
5ab63ab
7067605
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -58,6 +58,7 @@ jobs: | |
| linux_test_labels: ${{ inputs.linux_test_labels || '' }} | ||
| prebuilt_stages: ${{ inputs.prebuilt_stages || '' }} | ||
| baseline_run_id: ${{ inputs.baseline_run_id || '' }} | ||
| build_pytorch: false | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note how |
||
|
|
||
| linux_build_and_test: | ||
| name: Linux::${{ fromJSON(needs.setup.outputs.linux_build_config || '{}').build_variant_label || 'skip' }} | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -68,6 +68,10 @@ def format_summary( | |
| lines.append("") | ||
| _append_test_rocm(lines, outputs) | ||
|
|
||
| lines.append("### build-pytorch") | ||
| lines.append("") | ||
| _append_build_pytorch(lines, outputs) | ||
|
|
||
| return "\n".join(lines) | ||
|
|
||
|
|
||
|
|
@@ -199,6 +203,32 @@ def _append_build_rocm( | |
| ) | ||
|
|
||
|
|
||
| def _append_build_pytorch(lines: list[str], outputs: CIOutputs) -> None: | ||
| lines.append("| Platform | Python | PyTorch ref | Families |") | ||
| lines.append("|----------|--------|-------------|----------|") | ||
|
|
||
| rows = 0 | ||
| for platform, config in [ | ||
| ("Linux", outputs.builds.linux), | ||
| ("Windows", outputs.builds.windows), | ||
| ]: | ||
| if config is None: | ||
| continue | ||
| for row in config.pytorch_build_matrix: | ||
| families = ", ".join( | ||
| f"`{family}`" for family in row["amdgpu_families"].split(";") | ||
| ) | ||
| lines.append( | ||
| f"| {platform} | `{row['python_version']}` | " | ||
| f"`{row['pytorch_git_ref']}` | {families} |" | ||
| ) | ||
| rows += 1 | ||
|
|
||
| if rows == 0: | ||
| lines.append("| — | — | — | — |") | ||
| lines.append("") | ||
|
|
||
|
|
||
|
Comment on lines
+206
to
+231
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is nice, having it in summary |
||
| def _append_test_rocm(lines: list[str], outputs: CIOutputs) -> None: | ||
| # Note: this assumes that the test_rocm job is never skipped. | ||
| # We may decide to skip it under certain conditions in the future | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that CI https://github.com/ROCm/TheRock/actions/workflows/multi_arch_ci.yml now has this input, just like the release workflow:
I'll also add "build_jax" in #6117