Skip to content

Halfdocs reorg #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 40 commits into
base: rocm
Choose a base branch
from
Draft

Halfdocs reorg #13

wants to merge 40 commits into from

Conversation

Rmalavally
Copy link

No description provided.

@pfultz2
Copy link
Collaborator

pfultz2 commented May 2, 2024

No documentation should be added to this repo. This is not an AMD/ROCM-maintained component. This repo is here only so we package the component as part of a rocm distribution. As such any documentation should be submitted upstream to the SVN repo here: https://sourceforge.net/p/half/code/HEAD/tree/

@Rmalavally
Copy link
Author

No documentation should be added to this repo. This is not an AMD/ROCM-maintained component. This repo is here only so we package the component as part of a rocm distribution. As such any documentation should be submitted upstream to the SVN repo here: https://sourceforge.net/p/half/code/HEAD/tree/

Thanks so much, Paul. Appreciate your feedback. Do you recommend we don't publish the Half documentation on the ROCm documentation portal? I believe we have Half listed in the list of ROCm components at https://rocm.docs.amd.com/en/latest/what-is-rocm.html. Please advise.

@pfultz2
Copy link
Collaborator

pfultz2 commented May 8, 2024

Do you recommend we don't publish the Half documentation on the ROCm documentation portal?

Yes, we shouldn't publish. We dont publish documentation for upstream LLVM either.

@Rmalavally
Copy link
Author

Do you recommend we don't publish the Half documentation on the ROCm documentation portal?

Yes, we shouldn't publish. We dont publish documentation for upstream LLVM either.

Noted, @pfultz2. Thanks for clarifying.
@yhuiYH FYI

Half-Precision Floating Point library (Version 1.12.0)
------------------------------------------------------

Half is a C++ header-only library to provide an IEEE 754 conformant 16-bit half-precision floating point type along with corresponding arithmetic operators, type conversions and common mathematical functions. It aims for both efficiency and ease of use, trying to accurately mimic the behaviour of the builtin floating point types at the best performance possible.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Half is a C++ header-only library to provide an IEEE 754 conformant 16-bit half-precision floating point type along with corresponding arithmetic operators, type conversions and common mathematical functions. It aims for both efficiency and ease of use, trying to accurately mimic the behaviour of the builtin floating point types at the best performance possible.
Half is a C++ header-only library that provides an IEEE 754 conformant 16-bit half-precision floating point type along with corresponding arithmetic operators, type conversions, and common mathematical functions. It aims for both efficiency and ease of use, trying to accurately mimic the behavior of the built-in floating point types at the best performance possible.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And shouldn't there be a link to a github repository after the intro?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And shouldn't there be a link to a github repository after the intro?

Thanks so much, Leo. I think the decision is to not publish Half API documentation on the portal. @yhuiYH Could you please confirm?


# Installing Half

The library in its most recent version can be obtained from here, see the [Release Notes](changelog.html) for further information:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't use "here" - it should be a link.
However, is the Changelog the right place


The library in its most recent version can be obtained from here, see the [Release Notes](changelog.html) for further information:

<ul class="tablist"><li>[Download half 1.12.0 (.zip)](http://sourceforge.net/projects/half/files/latest/download)</li></ul>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This formatting looks messed up.
image


If you are interested in previous versions of the library, see the [SourceForge download page](http://sourceforge.net/projects/half/files/half).

Comfortably enough, the library consists of just a single header file containing all the functionality, which can be directly included by your projects, without the neccessity to build anything or link to anything.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Comfortably enough, the library consists of just a single header file containing all the functionality, which can be directly included by your projects, without the neccessity to build anything or link to anything.
The library consists of just a single header file containing all the functionality, which can be directly included by your projects, without the necessity to build anything or link to anything.

symbol.


IMPLEMENTATION

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a heading style

conceptually clean half-precision implementation, to which the standard
mathematical functions belong, even if usually not needed.

IEEE CONFORMANCE

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a heading style

Using Half
-----------

To make use of the library just include its only header file half.hpp, which defines all half-precision functionality inside the 'half_float' namespace. The actual 16-bit half-precision data type is represented by the 'half' type. This

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To make use of the library just include its only header file half.hpp, which defines all half-precision functionality inside the 'half_float' namespace. The actual 16-bit half-precision data type is represented by the 'half' type. This
To use the library, include its only header file half.hpp, which defines all half-precision functionality, inside the 'half_float' namespace. The actual 16-bit half-precision data type is represented by the 'half' type. This

-----------

To make use of the library just include its only header file half.hpp, which defines all half-precision functionality inside the 'half_float' namespace. The actual 16-bit half-precision data type is represented by the 'half' type. This
type behaves like the builtin floating point types as much as possible, supporting the usual arithmetic, comparison and streaming operators, which makes its use pretty straight-forward:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
type behaves like the builtin floating point types as much as possible, supporting the usual arithmetic, comparison and streaming operators, which makes its use pretty straight-forward:
type behaves like the builtin floating point types as much as possible, supporting the usual arithmetic, comparison and streaming operators, which makes its use pretty straightforward:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bulit-in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants