[Comgr] Fix caching of Address Sanitizer bitcode in comgr-clang-command#3036
Open
MixedMatched wants to merge 1 commit into
Open
[Comgr] Fix caching of Address Sanitizer bitcode in comgr-clang-command#3036MixedMatched wants to merge 1 commit into
MixedMatched wants to merge 1 commit into
Conversation
lamb-j
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
-mlink-bitcode-fileto comgr-clang-command's path arguments whitelist. Also, add a cached version of the HIP ASAN test.Because
asanrtl.bc's symbols have to be external, it's linked using-mlink-bitcode-file. That flag wasn't in the path args whitelist for comgr-clang-command, so the tmp paths assertion failed.