Skip to content

amd-staging: Remove sram_ecc_legacy flags #3059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arsenm wants to merge 1 commit into
base: arsenm/openmp-upstream-divergence-getAMDGPUTargetFeatures-signature
Choose a base branch
from
+0 −9
Open

amd-staging: Remove sram_ecc_legacy flags #3059

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions clang/include/clang/Options/Options.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5999,8 +5999,6 @@ def mcode_object_version_EQ : Joined<["-"], "mcode-object-version=">, Group<m_Gr
defm cumode : SimpleMFlag<"cumode",
"Specify CU wavefront", "Specify WGP wavefront",
" execution mode (AMDGPU only)", m_amdgpu_Features_Group>;
defm sram_ecc_legacy : SimpleMFlag<"sram-ecc", "", "",
"Legacy option to specify SRAM ECC mode (AMDGPU only)">;
defm tgsplit : SimpleMFlag<"tgsplit", "Enable", "Disable",
" threadgroup split execution mode (AMDGPU only)", m_amdgpu_Features_Group>;
defm xnack : SimpleMFlag<"xnack", "Enable", "Disable",
Expand Down
7 changes: 0 additions & 7 deletions clang/lib/Driver/ToolChains/AMDGPU.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -676,13 +676,6 @@ void amdgpu::getAMDGPUTargetFeatures(const Driver &D,
options::OPT_mno_wavefrontsize64, false))
Features.push_back("+wavefrontsize64");

// TODO: Remove during upstreaming target id.
if (Args.getLastArg(options::OPT_msram_ecc_legacy)) {
Features.push_back("+sramecc");
}
if (Args.getLastArg(options::OPT_mno_sram_ecc_legacy)) {
Features.push_back("-sramecc");
}
if (Args.hasFlag(options::OPT_mamdgpu_precise_memory_op,
options::OPT_mno_amdgpu_precise_memory_op, false))
Features.push_back("+precise-memory");
Expand Down