[Comgr] Assert hotswap RSRC1 field layout assumptions#3072
Open
lamb-j wants to merge 1 commit into
Open
Conversation
The hotswap ELF code reads/writes the GRANULATED VGPR and SGPR count fields of COMPUTE_PGM_RSRC1 at fixed shifts/widths. Add static_asserts pinning those layout assumptions so any change is caught at compile time.
|
I suppose I understand the reason for this PR, but do we not want a safer fallback thats more than just asserts ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hotswap ELF code reads/writes the GRANULATED VGPR and SGPR count fields of
COMPUTE_PGM_RSRC1at fixed shifts/widths. Addstatic_asserts pinning those layout assumptions so any change is caught at compile time rather than producing incorrect rewrites.