Skip to content

AMDGPU: reduce hotswap helper duplication#3138

Merged
chinmaydd merged 1 commit into
ROCm:amd-stagingfrom
harsh-amd:comgr-hotswap-redundancy-cleanup
Jul 7, 2026
Merged

AMDGPU: reduce hotswap helper duplication#3138
chinmaydd merged 1 commit into
ROCm:amd-stagingfrom
harsh-amd:comgr-hotswap-redundancy-cleanup

Conversation

@harsh-amd

Copy link
Copy Markdown

Summary:

  • Share the hotswap uint64 overflow-checked add helper between ELF growth and entry-trampoline code.
  • Collapse duplicated retargetCodeObject output-buffer allocation/copy handling.
  • Keep behavior unchanged and independent of the hotswap lit-test PR.

This addresses the implementation-redundancy feedback from #3008 in a separate refactor PR. It is based directly on amd-staging and touches only hotswap implementation helper code, so it can be reviewed in parallel with #3098.

Verification:

  • cmake --build build --target hotswap-rewrite -- -j8
  • cmake --build build --target HotswapMCTests -- -j8
  • build/bin/HotswapMCTests
  • build/bin/llvm-lit -sv build/tools/comgr/test-lit --filter hotswap

@harsh-amd harsh-amd added comgr Related to Code Object Manager hotswap Related to the Comgr Hotswap feature labels Jul 1, 2026
@harsh-amd harsh-amd force-pushed the comgr-hotswap-redundancy-cleanup branch from efa8111 to bc4e2f9 Compare July 1, 2026 13:08

@chinmaydd chinmaydd left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

Also, request to keep the commit message to a minimal description of the change being made. A lot of the comments from the PR description can be elided.

@chinmaydd chinmaydd merged commit 00856fc into ROCm:amd-staging Jul 7, 2026
54 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comgr Related to Code Object Manager hotswap Related to the Comgr Hotswap feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants