Skip to content

Eliminates duplicate system environment data collection #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
coketaste wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −4
Open

Eliminates duplicate system environment data collection #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/madengine/tools/run_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,13 +315,13 @@ def apply_tools(
def gather_system_env_details(
self,
pre_encapsulate_post_scripts: typing.Dict,
model_name: str
container_identifier: str
) -> None:
"""Gather system environment details.

Args:
pre_encapsulate_post_scripts: The pre, encapsulate and post scripts.
model_name: The model name.
container_identifier: The container name or image identifier (replaces model_name for container-specific env files).

Returns:
None
Expand All @@ -331,11 +331,13 @@ def gather_system_env_details(

Note:
This function is used to gather system environment details.
Uses container_identifier instead of model_name to ensure multiple models
running on the same container share the same environment file.
"""
# initialize pre_env_details
pre_env_details = {}
pre_env_details["path"] = "scripts/common/pre_scripts/run_rocenv_tool.sh"
pre_env_details["args"] = model_name.replace("/", "_") + "_env"
pre_env_details["args"] = container_identifier + "_env"
pre_encapsulate_post_scripts["pre_scripts"].append(pre_env_details)
print(f"pre encap post scripts: {pre_encapsulate_post_scripts}")

Expand Down Expand Up @@ -780,7 +782,7 @@ def run_model_impl(

# add system environment collection script to pre_scripts
if self.args.generate_sys_env_details or self.context.ctx.get("gen_sys_env_details"):
self.gather_system_env_details(pre_encapsulate_post_scripts, info['name'])
self.gather_system_env_details(pre_encapsulate_post_scripts, container_name)
# run pre_scripts
if pre_encapsulate_post_scripts["pre_scripts"]:
self.run_pre_post_script(model_docker, model_dir, pre_encapsulate_post_scripts["pre_scripts"])
Expand Down