Fix the empty CSV result when run deprecated models #37
+11
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e CSV with a "SKIPPED" status, making it clear in reports which models were skipped due to deprecation.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where deprecated models would leave empty entries in the CSV output by ensuring skipped deprecated models are properly recorded with a "SKIPPED" status. The fix improves reporting clarity by explicitly marking which models were skipped due to deprecation.
Key changes:
- Reorganized the deprecated model handling logic to record skipped models in the CSV
- Added proper status tracking and CSV update for deprecated models that are skipped
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
The deprecated models will now be properly recorded in the performance CSV with a "SKIPPED" status, making it clear in reports which models were skipped due to deprecation.
Test Plan
Test Result
Submission Checklist