Pass ROCm package rocm_package_find_links_url through JAX release workflow#65
Merged
Conversation
ScottTodd
reviewed
Jun 24, 2026
ScottTodd
approved these changes
Jun 25, 2026
ScottTodd
left a comment
ScottTodd
left a comment
Member
There was a problem hiding this comment.
LGTM once the floating pins are switched back to main instead of your user branch
erman-gurses
changed the title
rocm_package_find_links_url through JAX release workflow
marbre
approved these changes
Jun 26, 2026
Member
|
Heads up, if cherry-picking this to the release branch next week, we need to pin to the release branch. |
Contributor
Author
I see - makes sense. |
erman-gurses
added a commit
to ROCm/TheRock
that referenced
this pull request
Jun 26, 2026
## Summary ISSUE ID: #3878 Related PR: ROCm/rockrel#65 Extend the JAX multi-arch release workflows to support both `rocm-jaxlib-v0.9.1` and `rocm-jaxlib-v0.10.0` release lines. ## Changes ### Release workflow - Add matrix support for: - `rocm-jaxlib-v0.9.1` - `rocm-jaxlib-v0.10.0` - Add release-line specific metadata: - `jax_repository` - `build_mode` - `gfx_arch` ### Build workflow #### rocm-jaxlib-v0.9.1 - Continue using the existing native build flow. - Build from `ROCm/rocm-jax`. - Continue using `build/ci_build`. #### rocm-jaxlib-v0.10.0 - Build from `ROCm/jax`. - Build a manylinux image using the release branch Dockerfile from `ROCm/rocm-jax`. - Build wheels inside the manylinux container using `build/build.py`. ### Testing On rockrel: https://github.com/ROCm/rockrel/actions/runs/28217952215/job/83613621212 https://github.com/ROCm/rockrel/actions/runs/28224689859 - Preserve existing GPU-family based runner selection through `configure_target_run.py`. - Add a JAX device visibility sanity check before running tests: ```bash python -c "import jax; print(jax.local_devices())" - Verified matrix expansion across Python 3.11–3.14. - Verified native build path for rocm-jaxlib-v0.9.1. - Verified manylinux build path for rocm-jaxlib-v0.10.0. - Verified release artifact publication. - Verified JAX device visibility check executes before tests. TODO: Run JAX builds inside a top-level GitHub Actions job container, similar to existing PyTorch workflows.
marbre
pushed a commit
to ROCm/TheRock
that referenced
this pull request
Jun 29, 2026
## Summary ISSUE ID: #3878 Related PR: ROCm/rockrel#65 Extend the JAX multi-arch release workflows to support both `rocm-jaxlib-v0.9.1` and `rocm-jaxlib-v0.10.0` release lines. ## Changes ### Release workflow - Add matrix support for: - `rocm-jaxlib-v0.9.1` - `rocm-jaxlib-v0.10.0` - Add release-line specific metadata: - `jax_repository` - `build_mode` - `gfx_arch` ### Build workflow #### rocm-jaxlib-v0.9.1 - Continue using the existing native build flow. - Build from `ROCm/rocm-jax`. - Continue using `build/ci_build`. #### rocm-jaxlib-v0.10.0 - Build from `ROCm/jax`. - Build a manylinux image using the release branch Dockerfile from `ROCm/rocm-jax`. - Build wheels inside the manylinux container using `build/build.py`. ### Testing On rockrel: https://github.com/ROCm/rockrel/actions/runs/28217952215/job/83613621212 https://github.com/ROCm/rockrel/actions/runs/28224689859 - Preserve existing GPU-family based runner selection through `configure_target_run.py`. - Add a JAX device visibility sanity check before running tests: ```bash python -c "import jax; print(jax.local_devices())" - Verified matrix expansion across Python 3.11–3.14. - Verified native build path for rocm-jaxlib-v0.9.1. - Verified manylinux build path for rocm-jaxlib-v0.10.0. - Verified release artifact publication. - Verified JAX device visibility check executes before tests. TODO: Run JAX builds inside a top-level GitHub Actions job container, similar to existing PyTorch workflows.
marbre
added a commit
to ROCm/TheRock
that referenced
this pull request
Jun 29, 2026
Cherry-picks 3b10211 into the 7.14 release branch. --- ## Summary ISSUE ID: #3878 Related PR: ROCm/rockrel#65 Extend the JAX multi-arch release workflows to support both `rocm-jaxlib-v0.9.1` and `rocm-jaxlib-v0.10.0` release lines. ## Changes ### Release workflow - Add matrix support for: - `rocm-jaxlib-v0.9.1` - `rocm-jaxlib-v0.10.0` - Add release-line specific metadata: - `jax_repository` - `build_mode` - `gfx_arch` ### Build workflow #### rocm-jaxlib-v0.9.1 - Continue using the existing native build flow. - Build from `ROCm/rocm-jax`. - Continue using `build/ci_build`. #### rocm-jaxlib-v0.10.0 - Build from `ROCm/jax`. - Build a manylinux image using the release branch Dockerfile from `ROCm/rocm-jax`. - Build wheels inside the manylinux container using `build/build.py`. ### Testing On rockrel: https://github.com/ROCm/rockrel/actions/runs/28217952215/job/83613621212 https://github.com/ROCm/rockrel/actions/runs/28224689859 - Preserve existing GPU-family based runner selection through `configure_target_run.py`. - Add a JAX device visibility sanity check before running tests: ```bash python -c "import jax; print(jax.local_devices())" - Verified matrix expansion across Python 3.11–3.14. - Verified native build path for rocm-jaxlib-v0.9.1. - Verified manylinux build path for rocm-jaxlib-v0.10.0. - Verified release artifact publication. - Verified JAX device visibility check executes before tests. TODO: Run JAX builds inside a top-level GitHub Actions job container, similar to existing PyTorch workflows. Co-authored-by: erman-gurses <99776114+erman-gurses@users.noreply.github.com>
marbre
added a commit
that referenced
this pull request
Jun 29, 2026
…orkflow (#65) (#68) Cherry-pick b775c04 into the 7.14 release branch. --- ## Summary Related PR: ROCm/TheRock#6054 Add `rocm_package_find_links_url` to the rockrel JAX release workflow and forward it to the reusable TheRock JAX build workflow. This allows the JAX manylinux build path to consume ROCm packages from a configurable package index instead of relying on a hardcoded URL. ## Changes * Add `rocm_package_find_links_url` workflow input to `multi_arch_release_linux_jax_wheels.yml` * Forward `rocm_package_find_links_url` to the reusable `multi_arch_build_linux_jax_wheels.yml` workflow * Default the value to the current dev multi-arch package index: * `https://rocm.devreleases.amd.com/whl-multi-arch/` ## Motivation The JAX manylinux build flow now installs ROCm packages from a package index. Passing the package source as an input allows the workflow to support different release channels (dev, nightly, prerelease) without hardcoding a specific index URL in the build workflow. Tests: https://github.com/ROCm/rockrel/actions/runs/28086158341 Co-authored-by: erman-gurses <99776114+erman-gurses@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related PR: ROCm/TheRock#6054
Add
rocm_package_find_links_urlto the rockrel JAX release workflow and forward it to the reusable TheRock JAX build workflow.This allows the JAX manylinux build path to consume ROCm packages from a configurable package index instead of relying on a hardcoded URL.
Changes
Add
rocm_package_find_links_urlworkflow input tomulti_arch_release_linux_jax_wheels.ymlForward
rocm_package_find_links_urlto the reusablemulti_arch_build_linux_jax_wheels.ymlworkflowDefault the value to the current dev multi-arch package index:
https://rocm.devreleases.amd.com/whl-multi-arch/Motivation
The JAX manylinux build flow now installs ROCm packages from a package index. Passing the package source as an input allows the workflow to support different release channels (dev, nightly, prerelease) without hardcoding a specific index URL in the build workflow.
Tests:
https://github.com/ROCm/rockrel/actions/runs/28086158341