ITK module transition #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anweighting applications
…pping Itk module python wrapping
ITK should handle this already when building the module. This is only required if PCT would build another third party before itk_module_impl
Fixes issues where the imp lib is not found when building sharedl libs on windows
SimonRit
reviewed
Feb 14, 2025
| ENDFOREACH(GGO_FILE) | ||
| SET_SOURCE_FILES_PROPERTIES(${${GGO_SRCS}} PROPERTIES GENERATED TRUE) | ||
| ENDMACRO (WRAP_GGO) | ||
| if (NOT TARGET gengetopt) |
There was a problem hiding this comment.
Could this file be taken from RTK cmake directory?
| @@ -0,0 +1,17 @@ | |||
| /*========================================================================= | |||
| * | |||
| * Copyright RTK Consortium | |||
There was a problem hiding this comment.
I'd rather use "Centre National de la Recherche Scientifique" for the copyrights, as in the license file
| @@ -0,0 +1,17 @@ | |||
| cmake_minimum_required(VERSION 3.16.3) | |||
There was a problem hiding this comment.
Should we maybe wait for an example before adding this? There doesn't seem to be any source file yet.
| ) | ||
|
|
||
| if(NOT ITK_SOURCE_DIR) | ||
| find_package(ITK REQUIRED COMPONENTS ITKImageIO ITKTransformIO ${ExampleSpecificComponents}) |
There was a problem hiding this comment.
Why would we need all these ITK components? Let's wait for a concrete example...
| @@ -0,0 +1,150 @@ | |||
| #ifndef __pctDDParkerShortScanImageFilter_txx | |||
There was a problem hiding this comment.
_txx -> _hxx in all files. I'm atually surprised this is not checked by kwstyle or clang-format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI pipeline will only run once it's merged I guess.
Temporary pipeline can be accessed here: https://github.com/LucasGandel/PCT/actions/runs/13201483553/job/36854352179