Improve interoperability of spectral filters #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ectorImage Two-steps spectral filters use itk::VectorImages as inputs, while rtkMechlemOneStepSpectralReconstructionFilter used itk::Image<itk::Vector> Overloaded SetInput methods now allow to use the same image for one-step and two-steps spectral reconstructions. Added a test case in rtkspectralonesteptest to test the overload
Two-steps spectral filters used itk::VectorImage<float, 2> as input format for the incidentSpectrum, while the one-step uses itk::Image<float, 3>, which is simpler. This commit modified the two-steps filters to use the same input format as the one-step one
Now that the two-step filters use an itk::Image<float, 3> as format for the incidentSpectrum, the test data must be modified accordingly
Fix a bug where the iterators on the incident spectrum images were moving to fast (same change as performed on the SpectralForwardModel earlier)
…tral filters The SetInputIncidentSpectrum and SetInputSecondIncidentSpectrum have previously been modified to take as input an itk::Image<float, 3> instead of an itk::VectorImage<float, 2>. This commit adds overloaded versions of these functions which use the old image type for backward compatibility
Those filters had been updated in C++ but their wrappings had not
The test must use both the newly formatted data for incidentSpectrum and the old one for legacy testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the image type of the incident spectrum in two-steps spectral filters to match that of the one-step filter (backward-compatible thanks to overloaded SetInput functions)
Overloaded the SetInput functions of the spectral one-step filter to accept the image type used by the two-steps filters.