Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3 Release #36

Merged
merged 25 commits into from
Jan 2, 2020
Merged

V3 Release #36

merged 25 commits into from
Jan 2, 2020

Conversation

bonedaddy
Copy link
Collaborator

@bonedaddy bonedaddy commented Dec 24, 2019

Simplify our API setup, and condenses what was completely separate API's into individual RPCs to reuse code as much as possible within TxPB, and in implementing libraries. Any low-level RPCs that interact with aspects of our custom node directly should be implemented within the NodeAPI. Anything that interacts with external services (file uploads, pubsub) are separate APIs.

Closes #35

Changes

  • Refactor DagAPI, KeystoreAPI, NodeAPI, and PubSubAPI to reuse as much code as possible
  • Move Blockstore RPC from AdminAPI to NodeAPI
  • Move DagAPI to NodeAPI
  • Move KeystoreAPI to NodeAPI
  • Enable ipfs pin add equivalent RPC called Persist
  • Fixes a bug with java util code not being generated properly

TODO:

* Comments
* DagAPI (done)
* KeystoreAPI (done)
* NodeAPI (done)
* PubSubAPI (done)

Copy link
Contributor

@xiegeo xiegeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I like the old style were different functions went into separated protobuf files, but that's just a personal preference.

@bonedaddy bonedaddy marked this pull request as ready for review December 31, 2019 21:01
@bonedaddy bonedaddy requested a review from xiegeo December 31, 2019 21:01
@bonedaddy bonedaddy merged commit d9a0863 into master Jan 2, 2020
@bonedaddy bonedaddy deleted the cleanup branch January 2, 2020 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor APIs
2 participants