Skip to content

Fix/issues 257 262 272 274 - #328

Merged
valoryyaa-byte merged 4 commits into
RWA-ToolKit:mainfrom
0xfaan:fix/issues-257-262-272-274
Aug 31, 2026
Merged

Fix/issues 257 262 272 274#328
valoryyaa-byte merged 4 commits into
RWA-ToolKit:mainfrom
0xfaan:fix/issues-257-262-272-274

Conversation

@0xfaan

@0xfaan 0xfaan commented Aug 30, 2026

Copy link
Copy Markdown

Summary

  • add deterministic server-side sorting for GET /assets by valuation, holders, and created ledger
  • generate the typed API client from the published OpenAPI spec so the docs and app types stay aligned
  • pin regressions to ensure unknown query parameters are ignored and GET-only endpoints return 405 Method Not Allowed

Changes

  • Added sort and order query support to GET /assets, with sorting applied before pagination.
  • Updated the API docs and published OpenAPI schema to document the new asset list parameters.
  • Added a small OpenAPI-to-TypeScript generation step and committed the generated docs/lib/api-client.ts output.
  • Hooked the docs app generation into the normal build/dev flow and replaced the hand-written example client typing with the generated types.
  • Added regression coverage for unknown query parameters and POST requests to GET-only routes.

Testing

  • node docs/scripts/generate-openapi-client.mjs
  • python -m json.tool docs/public/openapi.json

Related issues

Closes #257
Closes #262
Closes #272
Closes #274

@drips-wave

drips-wave Bot commented Aug 30, 2026

Copy link
Copy Markdown

@0xfaan Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@valoryyaa-byte
valoryyaa-byte merged commit 3c08f89 into RWA-ToolKit:main Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants