Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add contentFor #31

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

add contentFor #31

wants to merge 5 commits into from

Conversation

sr3d
Copy link

@sr3d sr3d commented Mar 1, 2013

Inspired by ejs-layout, I update the code to support contentFor block with following syntax:

inside the view

<%- contentFor('leftNav') -%>
<ul>
 ...
</ul>

<%- contentFor('someOtherSection') -%>
....

inside the layout

<%- contentFor.leftNav -%>
.. // snipped ...
<%- contentFor.someOtherSection -%>

- update README.md
- add instruction for contentFor
supports for extended block of HTML to be included in the layout.  Inspired by ejs-layout 
@RandomEtc
Copy link
Owner

Sounds great! Apologies if it takes a few days to get to testing/merging
this. Thanks for the contribution!

@medanat
Copy link

medanat commented Mar 16, 2013

+1

@Vadorequest
Copy link

This would be awesome. I'm wondering about one thing, when is stopped the code included into a contentFor in the View?

I mean, if I want to set some contentFor, in the example it looks like it pass all the code until the next contentFor. But what if I want to have some kind of end to have source code that won't be in any contentFor?

<%- contentFor('leftNav') -%>
<ul>
 ...
</ul>
// Stop it, the block for leftNav ends here.
<%- contentForEnd('leftNav') -%>

// This isn't in any contentFor block.
<div>tralala</div>

// Another contentFor block?
<%- contentFor('someOtherSection') -%>
....

Here we could end a block manually to stop and it would allow to have some code after the block that belongs to the view.

The issue with the current solution is that we need to set the contentFor blocks at the end of the file, else we wouldn't be able to "stop" a block. I hope I've been clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants