Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: percent ์†Œ์ˆ˜์  ์ฒ˜๋ฆฌ #192

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

Umjiseung
Copy link
Collaborator

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

percent์˜ ์†Œ์ˆ˜์ ์„ ์ฒ˜๋ฆฌํ•˜์ง€ ์•Š์•„ ์†Œ์ˆ˜์ ์ด ์ „์ฒด๊ฐ€ ๋‚˜์™€ ์ˆ˜์ •ํ•˜์˜€์Šต๋‹ˆ๋‹ค

Resolves: #191

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

percent์˜ ์†Œ์ˆ˜์ ์„ Math์˜ floor๋ฅผ ์‚ฌ์šฉํ•˜์—ฌ ์ฒ˜๋ฆฌํ•˜์˜€์Šต๋‹ˆ๋‹ค

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

ํ…œํ”Œ๋ฆฟ ์ฒดํฌ๋ฆฌ์ŠคํŠธ ๋ง๊ณ ๋„ ์ถ”๊ฐ€์ ์œผ๋กœ ํ•„์š”ํ•œ ์ฒดํฌ๋ฆฌ์ŠคํŠธ๋Š” ์ถ”๊ฐ€ํ•ด์ฃผ์„ธ์š”!

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. .env, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "ํ™˜๊ฒฝ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

@Umjiseung Umjiseung added 1๏ธโƒฃPriority: High ์šฐ์„ ์ˆœ์œ„ ์ƒ ๐Ÿ”จ Refactor ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง labels Jul 16, 2024
@Umjiseung Umjiseung self-assigned this Jul 16, 2024
@Umjiseung Umjiseung merged commit 1a468f7 into develop Jul 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1๏ธโƒฃPriority: High ์šฐ์„ ์ˆœ์œ„ ์ƒ ๐Ÿ”จ Refactor ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง
Projects
None yet
Development

Successfully merging this pull request may close these issues.

๋ณด์œ ์ค‘์ธ ํฌ์ธํŠธ์˜ ์†Œ์ˆ˜์  ์ฒ˜๋ฆฌ
1 participant