Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: ๋กœ๊ทธ์ธ ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ถ”๊ฐ€ #217

Merged
merged 3 commits into from
Oct 3, 2024

Conversation

Umjiseung
Copy link
Collaborator

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

๋กœ๊ทธ์ธ ๋กœ์ง๊ด€๋ จ ํ…Œ์ŠคํŠธ ์ฝ”๋“œ๋ฅผ ์ถ”๊ฐ€ํ•˜์˜€์Šต๋‹ˆ๋‹ค

Resolves: #{์ด์Šˆ๋ฒˆํ˜ธ}

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

  • ๏ฟฝSignInServiceImplTest ์ถ”๊ฐ€

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

ํ…œํ”Œ๋ฆฟ ์ฒดํฌ๋ฆฌ์ŠคํŠธ ๋ง๊ณ ๋„ ์ถ”๊ฐ€์ ์œผ๋กœ ํ•„์š”ํ•œ ์ฒดํฌ๋ฆฌ์ŠคํŠธ๋Š” ์ถ”๊ฐ€ํ•ด์ฃผ์„ธ์š”!

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. .env, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "ํ™˜๊ฒฝ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

@Umjiseung Umjiseung added 2๏ธโƒฃPriority: Medium ์šฐ์„ ์ˆœ์œ„ ์ค‘ โœจ Feature ๊ธฐ๋Šฅ ๊ฐœ๋ฐœ โœ… Test test ๊ด€๋ จ(xctest, rxtest, nimble ...color) labels Oct 3, 2024
@Umjiseung Umjiseung self-assigned this Oct 3, 2024
@Umjiseung Umjiseung linked an issue Oct 3, 2024 that may be closed by this pull request
@Umjiseung Umjiseung merged commit c977a1f into develop Oct 3, 2024
1 check passed
@Umjiseung Umjiseung deleted the feature/214-signin-test-code branch October 3, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2๏ธโƒฃPriority: Medium ์šฐ์„ ์ˆœ์œ„ ์ค‘ โœจ Feature ๊ธฐ๋Šฅ ๊ฐœ๋ฐœ โœ… Test test ๊ด€๋ จ(xctest, rxtest, nimble ...color)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

๋กœ๊ทธ์ธ ํ…Œ์ŠคํŠธ ์ฝ”๋“œ
1 participant