Skip to content

Add missing PyPI environment for OIDC#6

Merged
RareBird15 merged 1 commit into
mainfrom
lanie/fix-pypi-handshake
Apr 10, 2026
Merged

Add missing PyPI environment for OIDC#6
RareBird15 merged 1 commit into
mainfrom
lanie/fix-pypi-handshake

Conversation

@RareBird15

Copy link
Copy Markdown
Owner

Summary

This change adds a missing environment configuration for the PyPI publishing job in the workflow.

What Changed

  • Introduced the environment: pypi line in the publish-pypi job.

Why

  • The addition resolves the absence of a specified environment for the PyPI publishing process, ensuring proper execution.

Validation

  • uvx ruff check .
  • uv run python -m unittest discover tests -v
  • I tested the affected workflow manually, if applicable

Accessibility Review

  • I considered how this change sounds in a screen reader, not just how it looks in a terminal
  • I did not add decorative ASCII, visual-only cues, or formatting that makes output harder to read aloud
  • Prompts, labels, and headings remain plain, predictable, and understandable

Content and Policy Review

  • I did not commit copyrighted EPUBs or generated plan content without explicit rights
  • I updated documentation if user-visible behavior changed
  • I updated CHANGELOG.md if this change is user-visible

Notes for Reviewers

  • Review the environment configuration to ensure it aligns with the intended deployment process.

Copilot AI review requested due to automatic review settings April 10, 2026 02:40
@RareBird15 RareBird15 added the github_actions Pull requests that update GitHub Actions code label Apr 10, 2026
@RareBird15 RareBird15 merged commit 57fb9da into main Apr 10, 2026
7 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the missing GitHub Actions job environment configuration required for PyPI “trusted publishing” via OIDC, so the release workflow’s PyPI publish step can execute with the expected environment context.

Changes:

  • Set environment: pypi on the publish-pypi job in the release workflow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@RareBird15 RareBird15 deleted the lanie/fix-pypi-handshake branch April 10, 2026 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants