Merged
Conversation
21b6ddf to
90dbc25
Compare
d9e1c34 to
cd3d964
Compare
jCabala
commented
Aug 14, 2025
Member
Author
There was a problem hiding this comment.
I accidantelly pushed those files on one of the previous PRs
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR abstracts common logic from FROST client example scripts into reusable helper functions, improves error handling and validation, and adds the examples to CI for automated testing.
- Extracted shared functionality into helper scripts for file management, server initialization, and client command execution
- Enhanced error handling with strict bash options (
set -euo pipefail) and improved validation of generated artifacts - Created a Docker-based CI workflow to run all examples automatically with proper dependency management
Reviewed Changes
Copilot reviewed 11 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| frost-client/examples/helpers/*.sh | New helper scripts abstracting common functionality for file generation, server initialization, and client command execution |
| frost-client/examples/*/example.sh | Refactored example scripts to use helpers with improved error handling and cleaner output |
| .github/workflows/*.yml | New CI workflows for building Docker image and running examples |
| .docker/frost-ci.Dockerfile | Docker image with pre-installed FROST dependencies for CI |
| frost-client/examples/README.md | Documentation explaining how to run examples and development workflow |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
… Updated error handling in client examples
cd3d964 to
160fffd
Compare
edwin1729
previously requested changes
Aug 14, 2025
edwin1729
reviewed
Aug 14, 2025
edwin1729
previously approved these changes
Aug 14, 2025
scaraven
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview:
Once this is merged to main I will need one more PR to update the image link in the workflow (See TODO comment in client-commands workflow)
closes #33
closes #54