Fix ambigous glob reexports in noise-0.7.0 #369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`perlin_surflet` only has one public item - `Perlin`, and it was never able to get to any public interfaces, because `perlin::Perlin` was always preferred.
petrochenkov
force-pushed
the
noambig
branch
from
25a43e9 to
7f3b2e3
Compare
Author
|
The patch is based on tag If the change needs to pass CI, then some checks will need to be disabled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Razaekel
As mentioned in rust-lang/rust#149195 (comment)
noise-0.7.0has a lot of crates depending on it, and all of them break because of the ambiguous reexport issue, so it would be nice to publish anoise-0.7.1if possible.perlin_surfletonly has one public item -Perlin, and it was never able to get to any public interfaces, becauseperlin::Perlinwas always preferred, so this change doesn't affect the public interface.