Skip to content

Conversation

@AlexMantilla1
Copy link

PR for the blocks/composite/folded_cascode opamp. This folder contains all files to sim and generate the layout. However the layout is done for bias and core circuits independtly, but not merged. We apologize, we know the code is messed up and be refactored in future versions.

All files have been ran in the chipathon_2025 docker container.

…s all files to sim and generate the layout. However the layout is done for bias and core circuits independtly, but not merged. We apologize, we know the code is messed up and be refactored in future versions.
@amisapta15
Copy link
Collaborator

Hi @AlexMantilla1 , Please help with a confusion. Your team is registered for the MOSBius track. Is this a single submission? Also, why there is a primitive.py? If there is something wrong with the code, would you please mind openning an issue and pushing an associated MR , fixing that before this?

@amisapta15
Copy link
Collaborator

Your current PR has too many changes making it hard to review. If you are facing bugs in the codebase, please issue smaller PRs fixing them, first so that we all benefit from the shared improved codebase.
Thanks

@AlexMantilla1
Copy link
Author

Hello @amisapta15 !

Thanks for checking! Yes we are formally registered in the MOSBius track. However, to achieve some of the goals of the project, we need to generate different "flavors" of the blocks we need. This is to generate the same circuits with different specs. Of course, glayout is perfect to perform the layout of these blocks.
Our team is divided in two: Onchip Design team and Onchip Layout team. Layout team (including me) is developing generators for different blocks, so we can easily configure the caracteristics of the desired block and then, generate the layout.
These blocks will be: Voltage controlled ring oscillator, Edge detectors, XOR-based phase detectors, static comparator, and a current reference generator (from previous chipathon).

Finally, yes right now we are working cleaning the code, we are really sorry about the code mess. We are learning the github flow. We are going to take your recommendation of creating smaller PRs and fixing smalls details of codebase functions, instead of creating a new one.

@amisapta15
Copy link
Collaborator

Hi @AlexMantilla1 That is great and thanks for explaining. Sounds exactly what gLayout is designed to do.

As you mentioned, when you are done with the code-cleanning, please push PRs for these blocks sperately (+ any bug fixes) and link the PRs here as top level. please don't forget to rebase always, before pushing. Devlopment work is going on.

@msaligane
Copy link
Member

@AlexMantilla1 any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants