Skip to content

Auto-correct RMG termination criterion #124

Description

@alongd

I ran a model generation with T3 with the following RMG termination criteria:

      termination_rate_ratio: 0.001
      termination_time: [60, 's']

RMG terminated once it reached the termination_rate_ratio:
At time 2.7169e-10 s, reached target termination RateRatio: 0.0009957255199092255

This is obviously not the intended behavior, since RMG terminated after less than a simulated time of a nano second only

We could add a minimal termination time to T3, and if some criterion causes it to terminate prematurely, T3 should modify that criterion and re-run RMG.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions