feat(range): add rh-range #870
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ex controller is resolved
* feat(label): add rh-label * test(label): rename e2e tests * fix(label): fix package-lock installed under incorrect npm version * docs(label): improve docs * fix(label): incorrect dep version in package.json * fix(label): use latest pfe-icon api and correct icon size * fix(label): revert dep version shorthand, increment * style(label): linting * refactor(label): rename to rh-tag * test(tag): fix import of RhTag * fix(tags): fix broken package-lock * docs(tag): import pfe-icon in demo js * fix(tags): add pfe-icon as a dependency * fix(tag): remove pfe-codeblock * docs(tag): improve README.md * fix(tag): remove orphaned pfe-band slots * fix(tag): remove set attribute * test(tag): improve spec tests * docs(tag): add changeset * docs(tag): imporove README.md
* fix(docs): removed spinner demo page from ux dot nav * docs(spinner): update package-lock * fix(docs): update package-lock and node modules * test(tag): don't test shadow dom * perf(tag): optimize css * fix(tag): implement abstract props Co-authored-by: Michael Potter <[email protected]> Co-authored-by: Benny Powers <[email protected]>
* doc: adding event listener example to rh-alert * doc: rh-alert event listener documentation reasoning * fix(alert): remove state switching to error after element is removed * docs(alert): adding section for preventing default close behavior to readme
* fix(tooltip): making on property private, adding wrapper to render, css for wrapper * chore(tooltip): fixing whitespace * chore: adding changeset * fix(tooltip): removing position test as it tests the shadow dom * docs: update changeset Co-authored-by: Benny Powers <[email protected]>
* docs(footer): fix demo icons * chore: revert previous * docs(footer): fix icons in demo
* feat: initial commit, adding rh-accordion, rh-accordion-panel, rh-accordion-header * fix: updating accordion styles * fix: adding in the styles from the ux docs, adding in large style and slotted font sizes * fix: adding dark theme support * fix: updating the styles to match the updated pfe-accordion styles, fixing stylelint issues * fix: adding disclosure to the accordion as an optionwhen only one panel is present * fix: removing disclosure specific code * fix: updating importmap for demo, updating instances of pfe-accordion to rh-accordion * fix: making border color dynamic between dark and light themes * fix: fixing styling on not-first-child rh-accordion-header and top for after element * chore: updating stylesheet to move vars into rh-accordion* files * chore: updating accordion version * fix: styling changes to the accordion, cleaning up variables * fix: updating the icon in the rh-accordion header to the new format * fix: angle down instead of arrow down * chore: adding changeset and removing max-width property * fix: package.json / package-lock and adding readme details and rh-footer fix * fix: renaming e2e spec file * fix: fixing import map to point to latest version, updating accordion njk to not have a demo for now * chore: Updating the demo page to not include disclosure and secondary dark theme demo * fix: adding cascade for large accordion, fixing header text wrapper and fixing shadow on top of panel * fix: updating package-lock sinon * fix: updating dark theme accent color to ff442b, adding token * style: updating rh-accordion var to match conventions and stylelint rules * docs(accordion): updating rh-accordion elements with descriptions of slots and purpose * fix(accordion): removing pfe-band, replacing with rh-context-provider and updating imports in rh-accordion * docs: update changeset * docs: uncomment example element * docs: update readme * docs(footer): update readme * fix(accordion): update upstream pfe-accordion * docs: update demos * fix: refactor accordion css * chore: update deps * docs: remove references to pfe-accordion * fix(demo): remove references to pfe-accordion * fix(footer): remove references to pfe-accordion * docs(secondary-nav): remove references to pfe-accordion * fix(accordion): remove pfe icon * fix(accordion): privatize `on` * fix(accordion): adding color context property, icon fill color, css panel spacing * fix(accordion): removing relect attr for consumer for panel, header * fix(accordion): dark theme border color, arrow direction, rotation, border right length on header * chore: skipping failing tag tests from merge * fix: removing skip from test, updating package-lock.json * fix(accordion): making border-right, padding css var into logical properties * fix(accordion): making on property private * docs(accordion): split off context demo * fix(accordion): context * fix(context)!: remove `attribute` from context consumer * fix(context): get attribute name from decorated property * docs(accordion): rtl * fix: make `on` private Co-authored-by: brian <[email protected]> Co-authored-by: Benny Powers <[email protected]> Co-authored-by: Benny Powers <[email protected]>
…o feat/rh-audio-player
- use `en-US` as default language code instead of `en`
- eagerly load copy for `en-US`
- revamp MicrocopyController to be a map of language tables
- add option to slot `<script type="application/json"
data-language="${langCode}">`
- Rename MicrocopyController to I18nController
…fixed hidden menu z-index
…esign-system into feat/rh-audio-player
…o feat/rh-audio-player
…o feat/rh-audio-player
🦋 Changeset detectedLatest commit: 2aacc7f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for red-hat-design-system ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Size Change: +46.1 kB (+25%) 🚨 Total Size: 229 kB
ℹ️ View Unchanged
|
markcaron
added
the
needs revisiting
|
@nikkimk this may need some revisiting, since it's old. Do you mind closing if this needs to be? Or provide more context if we're keeping this open? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
rh-rangeits own branch so thatrh-audio-playercan continue without the component.Resolve accessibility issues identified by axe DevTools:
aria-label attribute cannot be used on a rh-range with no valid role attributearia-hidden element must not be focusable nor contain focusable elementsTesting Instructions
Notes to Reviewers