[MOD-9576] make CreatePreprocessorsContainerParams templated and move it to header file #670
+448
−147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er file add logic to determine the cosine processed_bytes_count add processed_bytes_count to the cosine component change blob_size param to the original blob size instead of processed_bytes_count in all preprocessing functions.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #670 +/- ##
==========================================
- Coverage 96.24% 96.22% -0.02%
==========================================
Files 112 111 -1
Lines 6278 6284 +6
==========================================
+ Hits 6042 6047 +5
- Misses 236 237 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
meiravgri
changed the title
add DummyChangeAllocSizePreprocessor class to test pp that changes the size add tests one will fail because the input blob size is not updated
meiravgri
commented
May 12, 2025
|
|
||
| for (auto pp : preprocessors) { | ||
| if (!pp) | ||
| break; | ||
| // modifies the memory in place | ||
| pp->preprocessStorageInPlace(blob, processed_bytes_count); | ||
| pp->preprocessStorageInPlace(blob, input_blob_size); |
There was a problem hiding this comment.
will be covered by svs code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add logic to determine the cosine processed_bytes_count
add processed_bytes_count to the cosine component
change blob_size param to the original blob size instead of processed_bytes_count in all preprocessing functions.
Describe the changes in the pull request
A clear and concise description of what the PR is solving.
Which issues this PR fixes
Main objects this PR modified
Mark if applicable