Skip to content

Adding merge functionality #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Adding merge functionality #19

wants to merge 1 commit into from

Conversation

K-Jo
Copy link

@K-Jo K-Jo commented Dec 15, 2018

No description provided.

@CLAassistant
Copy link

CLAassistant commented Dec 15, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Glitchfix
Copy link
Contributor

Hi @K-Jo ,
I am not pretty sure if this could work as relations are not the same as edges in this case. Creating a node id to node id relation i.e. creating an edge doesn't work with MERGE query, which happens to be a weird case. This is why I created a separate method to handle it in #17

@gkorland gkorland requested a review from swilly22 January 14, 2020 15:08
@boris-42
Copy link
Contributor

IMHO this won't solve the problem, we should adjust code to use MERGE + SET for node updates, I created issue here: #81

@gkorland gkorland closed this May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swilly22 swilly22 Awaiting requested review from swilly22

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@K-Jo @CLAassistant @Glitchfix @boris-42 @gkorland