Skip to content

Conversation

hyungryuk-zz
Copy link

need to put geo data into redis using spark.

so i just add some lines

@CLAassistant
Copy link

CLAassistant commented Nov 28, 2018

CLA assistant check
All committers have signed the CLA.

@gkorland gkorland requested a review from fe2s November 29, 2018 23:16
Copy link
Contributor

@fe2s fe2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a test to RedisRddSuite for this method?

@@ -242,6 +242,18 @@ class RedisContext(@transient val sc: SparkContext) extends Serializable {
}
}

/**
* @param kvs RDD of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please complete the description of kvs parameter.

/**
* @param geoName
* @param arr k/vs which should be saved in the target host
* save all the k/vs to zsetName(zset type) to the target host
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks to be wrong. Copy pasted from another method?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants