{s/c/d/z}geqrf: document workspace query for empty matrices#1304
Open
jschueller wants to merge 1 commit into
Open
{s/c/d/z}geqrf: document workspace query for empty matrices#1304jschueller wants to merge 1 commit into
jschueller wants to merge 1 commit into
Conversation
Collaborator
|
If I read the later comments on the linked issue correctly, the intention was to keep it open until everybody is convinced that there are no similar cases (of returning an invalid workspace size when there's no work to do) left in other functions ? |
Clarify that the workspace query returns a valid LWORK (>= 1) even when MIN(M,N) = 0. The code already handles this correctly; this is purely a documentation update.
Contributor
Author
|
fair enough, lets leave it open |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify that the workspace query returns a valid LWORK (>= 1) even when MIN(M,N) = 0. The code already handles this correctly; this is purely a documentation update.
see #257