sblas3: Exclude from double precision build#1310
Closed
jschueller wants to merge 1 commit into
Closed
Conversation
Contributor
|
I think we need the single precision BLAS routines because if we build LAPACK with only double precision, these single precision routines are also compiled (SRC/CMakeLists.txt:166): Those are needed for the mixed precision routines, like We could build those only if both single and double precision are enabled. Or we introduce a new CMake variable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When only
BUILD_DOUBLEis enabled (withoutBUILD_SINGLE), the single-precision Level 3 BLAS routines (sgemm, ssymm, ssyrk, strsm, etc.) are still compiled into the BLAS library. This appears to be a copy-paste error —SBLAS3should not be in theBUILD_DOUBLEsection. While the object files may be ignored at link time, they bloat the build and may cause unexpected symbol exports.