Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FINALLY add a benchmark script. We should've had this from the beginning. #39

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

NHDaly
Copy link
Member

@NHDaly NHDaly commented Jan 26, 2025

This is the status as of now:

julia> include("bench/runbench.jl")
  11.000 ns (0 allocations: 0 bytes)
  61.641 ns (0 allocations: 0 bytes)
  2.833 ns (0 allocations: 0 bytes)
  15.489 ns (0 allocations: 0 bytes)
  4.000 ns (0 allocations: 0 bytes)
  26.104 ns (0 allocations: 0 bytes)
  2.250 ns (0 allocations: 0 bytes)
  2.291 ns (0 allocations: 0 bytes)
  2.250 ns (0 allocations: 0 bytes)
  2.250 ns (0 allocations: 0 bytes)
  2.291 ns (0 allocations: 0 bytes)
  2.291 ns (0 allocations: 0 bytes)
  2.291 ns (0 allocations: 0 bytes)
  2.291 ns (0 allocations: 0 bytes)
0

(And here is the above benchmark run on v0.5.1 - when everything used @generated functions. You can see that we have recovered all of that performance.):

julia> include("bench/runbench.jl")
  10.844 ns (0 allocations: 0 bytes)
  62.855 ns (0 allocations: 0 bytes)
  3.041 ns (0 allocations: 0 bytes)
  16.074 ns (0 allocations: 0 bytes)
  4.416 ns (0 allocations: 0 bytes)
  26.230 ns (0 allocations: 0 bytes)
  2.833 ns (0 allocations: 0 bytes)
  2.834 ns (0 allocations: 0 bytes)
  2.916 ns (0 allocations: 0 bytes)
  2.833 ns (0 allocations: 0 bytes)
  2.833 ns (0 allocations: 0 bytes)
  2.833 ns (0 allocations: 0 bytes)
  2.833 ns (0 allocations: 0 bytes)
  2.833 ns (0 allocations: 0 bytes)
0

Copy link
Contributor

@Sacha0 Sacha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Nathan! This is great :).

Base automatically changed from nhd-unsafe_load-large-structs to main January 31, 2025 17:13
…ing.

This is the status as of now:
```julia
julia> include("bench/runbench.jl")
  11.000 ns (0 allocations: 0 bytes)
  61.641 ns (0 allocations: 0 bytes)
  2.833 ns (0 allocations: 0 bytes)
  15.489 ns (0 allocations: 0 bytes)
  4.000 ns (0 allocations: 0 bytes)
  26.104 ns (0 allocations: 0 bytes)
  2.250 ns (0 allocations: 0 bytes)
  2.291 ns (0 allocations: 0 bytes)
  2.250 ns (0 allocations: 0 bytes)
  2.250 ns (0 allocations: 0 bytes)
  2.291 ns (0 allocations: 0 bytes)
  2.291 ns (0 allocations: 0 bytes)
  2.291 ns (0 allocations: 0 bytes)
  2.291 ns (0 allocations: 0 bytes)
0
```

(And here is the above benchmark run on v0.5.1 - when everything
used `@generated` functions. You can see that we have recovered all of
that performance.):
```julia
julia> include("bench/runbench.jl")
  10.844 ns (0 allocations: 0 bytes)
  62.855 ns (0 allocations: 0 bytes)
  3.041 ns (0 allocations: 0 bytes)
  16.074 ns (0 allocations: 0 bytes)
  4.416 ns (0 allocations: 0 bytes)
  26.230 ns (0 allocations: 0 bytes)
  2.833 ns (0 allocations: 0 bytes)
  2.834 ns (0 allocations: 0 bytes)
  2.916 ns (0 allocations: 0 bytes)
  2.833 ns (0 allocations: 0 bytes)
  2.833 ns (0 allocations: 0 bytes)
  2.833 ns (0 allocations: 0 bytes)
  2.833 ns (0 allocations: 0 bytes)
  2.833 ns (0 allocations: 0 bytes)
0
```
@NHDaly NHDaly merged commit 012c618 into main Jan 31, 2025
4 checks passed
@NHDaly NHDaly deleted the nhd-bench branch January 31, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants