Don't filter Core methods from newly-inferred list
#238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpamnany
force-pushed
the
kp-backport-58510
branch
from
16d06e4 to
19171cc
Compare
kpamnany
force-pushed
the
kp-backport-58510
branch
2 times, most recently
from
0a3cfa7 to
38a663a
Compare
Now that we re-export quite a lot from `Core` it seems sensible to
remove. This allows constructors like `Tuple{Type{Vector{Foo}},
UndefInitializer, Tuple{Int}}` to precompile properly.
Appears to have a minimal effect on the stdlib pkgimages:
```julia
--- before.txt 2025-05-23 08:36:20.171870043 -0400
+++ after.txt 2025-05-22 14:48:49.003869097 -0400
@@ -47,7 +47,7 @@
20K ../julia/usr/share/julia/compiled/v1.13/Logging/pkgimage.so
20K ../julia/usr/share/julia/compiled/v1.13/Logging/pkgimage.so
3.5M ../julia/usr/share/julia/compiled/v1.13/Markdown/pkgimage.so
-3.6M ../julia/usr/share/julia/compiled/v1.13/Markdown/pkgimage.so
+3.5M ../julia/usr/share/julia/compiled/v1.13/Markdown/pkgimage.so
184K ../julia/usr/share/julia/compiled/v1.13/Mmap/pkgimage.so
184K ../julia/usr/share/julia/compiled/v1.13/Mmap/pkgimage.so
28K ../julia/usr/share/julia/compiled/v1.13/MozillaCACerts_jll/pkgimage.so
```
kpamnany
force-pushed
the
kp-backport-58510
branch
from
38a663a to
fdb026b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Now that we re-export quite a lot from
Coreit seems sensible to remove. This allows constructors likeTuple{Type{Vector{Foo}}, UndefInitializer, Tuple{Int}}to precompile properly.Appears to have a minimal effect on the stdlib pkgimages:
Checklist
Requirements for merging:
Coremethods from newly-inferred list JuliaLang/julia#58510port-to-*labels that don't apply.