Pin RemitwiseEvents topic taxonomy tests#1043
Closed
Dreamstore2046 wants to merge 1 commit into
Closed
Conversation
4e3766b to
e4cc5ce
Compare
Author
|
CI follow-up:
|
e4cc5ce to
d479a21
Compare
Author
|
Follow-up push: I also added a minimal reporting compile unblock because the full workspace CI was failing before it could validate this PR's remitwise-common tests. The reporting changes are limited to:
I kept the changes unwrap/expect-free and verified git diff --check locally. |
3a58eac to
012a2a0
Compare
012a2a0 to
57792de
Compare
Author
|
Latest CI status after the follow-up pushes:
I stopped short of broadening this PR into a family_wallet test/auth refactor because that failure appears outside the event taxonomy change and would be much larger than this issue's scope. |
Contributor
|
thanks for the contribution! please get assigned to the issue before raising a PR (no assigned issue is linked to you here). closing as invalid for now 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1035.\n\n## Summary\n- add tests pinning every EventCategory discriminant\n- add tests pinning every EventPriority discriminant\n- assert RemitwiseEvents::emit publishes the (Remitwise, category, priority, action) topic tuple and payload\n- assert RemitwiseEvents::emit_batch publishes the fixed batch topic tuple and (action, count) payload, including zero-count batches\n- document the regression coverage in docs/EVENT_TAXONOMY.md\n\n## Validation\n- git diff --check\n\n## Notes\n- I could not run cargo fmt/test locally because this Windows environment does not have cargo/rustfmt installed (cargo and
ustfmt are not recognized on PATH). The patch is limited to remitwise-common tests plus taxonomy docs so CI should exercise the Rust validation.