test(utils): add pagination helper unit tests#912
Merged
Baskarayelu merged 1 commit intoJun 29, 2026
Merged
Conversation
d7081c4 to
8675a97
Compare
- Fixed validatePaginationParams to handle limit: 0 correctly (was treated as falsy) - Added edge case tests for limit: 1000, empty string cursor, numeric IDs - Added property-based tests for limit clamping and cursor passthrough closes Remitwise-Org#873
8675a97 to
52dfe3c
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds comprehensive unit tests for the cursor pagination helpers in lib/utils/pagination.ts.
Changes
Bug Fix
Test Coverage Added
Why This Matters
These helpers are shared infrastructure used by remittance/bills/goals routes. The clamping and cursor handling were previously untested, so a regression in the limit bounds would silently affect every paginated endpoint.
Acceptance Criteria Met
closes #873