Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI ARM #254

Merged
merged 4 commits into from
Mar 17, 2025
Merged

CI ARM #254

merged 4 commits into from
Mar 17, 2025

Conversation

johnnynunez
Copy link
Contributor

This pull request includes several changes to the .github/workflows/external.ci.yml file to enhance the CI pipeline by adding support for ARM builds and cleaning up existing job definitions.

Enhancements to CI pipeline:

  • Added new build job build-cpu-rocky-8-arm to support ARM architecture using arm64v8/rockylinux:8 container. This includes steps to install necessary packages, checkout the repository, build the project, and upload the build artifacts.
  • Added new build job build-cpu-ubuntu-2204-arm to support ARM architecture using arm64v8/ubuntu:22.04 container. This includes steps to install necessary packages, checkout the repository, build the project, and upload the build artifacts.

Cleanup:

  • Removed redundant comments related to file permission issues during artifact upload/download in the test-cpu-rocky-8 and test-cpu-ubuntu-2204 jobs. [1] [2]
  • Removed unnecessary blank lines in the test-cpu-rocky-8 and test-cpu-ubuntu-2204 job definitions for better readability. [1] [2]

@johnnynunez
Copy link
Contributor Author

johnnynunez commented Mar 14, 2025

@kraszkow done! I was travelling sorry

@kraszkow
Copy link
Contributor

Thanks @johnnynunez ! Would you mind adding also testing jobs to ARM (on CPU) to this PR?

@johnnynunez
Copy link
Contributor Author

Thanks @johnnynunez ! Would you mind adding also testing jobs to ARM (on CPU) to this PR?

Done

@johnnynunez
Copy link
Contributor Author

if you can do new release with new .tar.gz aarch64 files... asap

@johnnynunez johnnynunez requested a review from kraszkow March 14, 2025 13:55
@kraszkow kraszkow merged commit 24baabd into RenderKit:master Mar 17, 2025
8 checks passed
@kraszkow
Copy link
Contributor

First of all - thank you for your contribution - it's merged!

if you can do new release with new .tar.gz aarch64 files... asap

Thanks for your request. Generating a new release that includes ARM64 Linux binaries isn't as straightforward as it might seem. It's not just a technical challenge—we also have internal considerations that require extra effort on our side.
We understand the demand for ARM64 builds and appreciate your patience. While we can't commit to an immediate release, we’ll evaluate how best to proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants