Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove v1 of hot_score from unified document #2146

Merged
merged 3 commits into from
Mar 3, 2025
Merged

Conversation

koutst
Copy link
Contributor

@koutst koutst commented Feb 28, 2025

  • The hot_score that is actually used is hot_score_v2
  • Rename hot_score_v2 to hot_score

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 26.66667% with 11 lines in your changes missing coverage. Please review.

Project coverage is 68.45%. Comparing base (512f30c) to head (ca6eecf).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/researchhub_document/hot_score_mixin.py 33.33% 2 Missing ⚠️
..._document/related_models/researchhub_post_model.py 0.00% 2 Missing ⚠️
src/search/documents/paper.py 33.33% 2 Missing ⚠️
src/search/documents/post.py 0.00% 2 Missing ⚠️
src/reputation/tasks.py 0.00% 1 Missing ⚠️
src/researchhub_document/tasks.py 0.00% 1 Missing ⚠️
...cument/views/researchhub_unified_document_views.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2146      +/-   ##
==========================================
- Coverage   68.57%   68.45%   -0.13%     
==========================================
  Files         428      427       -1     
  Lines       23011    22859     -152     
==========================================
- Hits        15779    15647     -132     
+ Misses       7232     7212      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@koutst koutst marked this pull request as ready for review February 28, 2025 13:44
@koutst koutst requested a review from a team as a code owner February 28, 2025 13:44
@koutst koutst force-pushed the remove-hot-score-v1 branch from eb14035 to 66644e4 Compare February 28, 2025 14:01
Copy link
Member

@gzurowski gzurowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🧹

@koutst koutst force-pushed the remove-hot-score-v1 branch from 5f11fd5 to ca6eecf Compare March 3, 2025 15:22
Copy link

sonarqubecloud bot commented Mar 3, 2025

@koutst koutst merged commit 1e7c2c2 into master Mar 3, 2025
3 of 5 checks passed
@koutst koutst deleted the remove-hot-score-v1 branch March 3, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants