Repository navigation
Repair Allow and OPTIONS semantics through route-level HTTP method - #160
Merged
Merged
Conversation
Make Allow generation and OPTIONS handling reflect effective HTTP semantics instead of raw declared route methods. Changes: - add route-level method metadata APIs in AbstractRoute for effective method matching and allowed-method reporting - teach ControllerRoute to advertise and match only the HTTP methods its target can actually handle, including HEAD via GET fallback - centralize Router Allow computation from effective route methods and add implicit OPTIONS when a path is routable - keep explicit OPTIONS dispatch separate from transparent OPTIONS so custom handlers still run correctly - align 405, transparent OPTIONS, and OPTIONS * responses around the same Allow set - add regression coverage for HEAD in Allow, explicit OPTIONS Allow headers, global and transparent OPTIONS, and ANY controller routes rejecting unsupported methods Verification: - composer qa
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #160 +/- ##
=========================================
Coverage ? 95.85%
Complexity ? 402
=========================================
Files ? 27
Lines ? 988
Branches ? 0
=========================================
Hits ? 947
Misses ? 41
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make Allow generation and OPTIONS handling reflect effective HTTP semantics instead of raw declared route methods.
Changes:
Verification: