Setup local testing for PurchaseTester Typescript #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdholtz
force-pushed
the
purchase-tester-typescript-local-testing
branch
from
d12cdf4 to
fef8eb9
Compare
joshdholtz
changed the title
beylmk
reviewed
Jan 7, 2022
| resolver: { | ||
| // Tells metro to look at for `react-native-purchases` | ||
| // This fixes issues with referencing file in package.json which | ||
| // creates a symlink and metro can't handle symlinks |
beylmk
reviewed
Jan 7, 2022
| resolverMainFields: ['source', 'react-native', 'main'], // will first look the source then main | ||
| }, | ||
|
|
||
| // Metro will automatically update when something is changed in this path |
beylmk
reviewed
Jan 7, 2022
| }, | ||
| }; | ||
| // IMPORTANT | ||
| // Make sure `npm install` is run in this refernced package's directory |
There was a problem hiding this comment.
Suggested change
| // Make sure `npm install` is run in this refernced package's directory | |
| // Make sure `npm install` is run in this referenced package's directory |
:)
There was a problem hiding this comment.
Typos are going to be my legacy at RevenueCat but I'll fix it this one time 🙃
beylmk
reviewed
Jan 7, 2022
| @@ -408,7 +408,7 @@ DEPENDENCIES: | |||
| - React-RCTVibration (from `../node_modules/react-native/Libraries/Vibration`) | |||
| - React-runtimeexecutor (from `../node_modules/react-native/ReactCommon/runtimeexecutor`) | |||
| - ReactCommon/turbomodule/core (from `../node_modules/react-native/ReactCommon`) | |||
| - RNPurchases (from `../../../`) | |||
| - RNPurchases (from `../../..`) | |||
There was a problem hiding this comment.
how does this get set now that it's not in the podfile? is that what metro is doing 😅 sorry if this is a dumb question
There was a problem hiding this comment.
Nah! Not dumb question at all. This is auto linked with the introduction of the new react-native.config.js file. So whenever pod install is run, RN looks inside of react-native.config.js and will see this path and install it with cocoa pods
joshdholtz
added a commit
that referenced
this pull request
Jan 13, 2022
* Initial commit of purchaseTester typescript example * Made things a little prettier for offering detail * Removed console log * Typescript example using local RNPurchases pod * Fix some things were states weren't updating * Trying to fix CircleCI * This is it * name isn't a thing for the RN builds * name also isn't a thing for iOS RN builds * Add set attributes which isnt really working yet * Fix broken test * Fix broken test... again * Ignore package-lock.json, try using rn/yarn_install on circleci, move RC init to app.tsx * Trying to get yarn_install to run in the example directory * Change yarn cache folder * Try bringing in the yarn install from the orb for testing * Try yarn cwd before calling rn/yarn_install * That didn't work * This should fix android * This should fix macos symlink issue * Reset cache to see if fix worked * Lets start over on circleci * Add path for yarn pod * Experimenting * This should do it * --cwd doesnt work with yarn pods * Need to warn install both examples * Try with rn/yarn_install but copied over with path param * Forgot to replace cache path * Cleanup because things works :) * Need to put path to ios directory * Use conditional logic and use --cwd if not empty string * Rename to use standard revenuecat tester package and bundle id * Bump to react-native-community/[email protected] * Rename isSetup to hasKeys * Setup local testing for PurchaseTester Typescript (#326) * This works so much better for local testing * Updated comments to be more helpful * Fixed typo * Need to await the initial fetchData * Rename storekit config file and add second target that does not use sk config file Co-authored-by: Josh Holtz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #320
Motivation
Use local repo for
react-native-purchasesinstead of pointing to published version to use for local developmentDescription
react-native.config.jsto define local decency for auto linkingmetro.config.jsto:package.jsonwithnodeModulesPathandwatchFoldersresolverMainFieldsto look atsourcesoreact-native-purchasesdoesn't use the compileddist.circleci/config.ymlyarn install(ornpm install) in the root directory because this as local dependency needs its ownnode_modules