Demo code review (shared)

[pkaminski]

This is a simple pull request on a clone of a random repo, so you can play with Reviewable a bit. It's not complex enough to demo all the features but it'll get you started. Note that it's shared between all visitors to the site, so I reset the state the review's state every so often to keep it from getting out of hand.

You play the role of a reviewer—the butterflies will guide you through Reviewable's main features. In a real review, it would be up to the reviewee to fix the code and reply to the comments, iterating like this until all files are reviewed and all comments resolved. Unfortunately, this is as far as the demo goes... Try it for real on your own pull request!

This pull request is specially configured to not send comments to GitHub. Normally, published comments will appear in the GitHub pull request, but I've disabled the feature in this demo so that you don't end up being spammed by all future comments after you send one.

---

This change is

[pkaminski]

Comments from the review on Reviewable.io

---

^{astropy/coordinates/angles.py, line 146 [r1] (raw file):}
Not sure if this is still needed?

---

^{astropy/coordinates/tests/test_sky_coord.py, line 153 [r5] (raw file):}
Need to add more tests later.

---

[leereilly]

Comments from the review on Reviewable.io

---

^{astropy/coordinates/tests/test_sky_coord.py, line 153 [r5] (raw file):}
reviewable.io is beautiful ! ❤️

---

[josephjang]

Comments from the review on Reviewable.io

---

^{astropy/coordinates/angle_utilities.py, line 162 [r5] (raw file):}
There's a difference in the style. UINT vs. ufloat.

---

[bstrand]

Comments from the review on Reviewable.io

---

^{astropy/coordinates/angle_utilities.py, line 397 [r5] (raw file):}
Would be helpful to describe the rounding strategy here.

---

[thockin]

Comments from the review on Reviewable.io

---

^{astropy/coordinates/angle_utilities.py, line 152 [r5] (raw file):}
I think you meant "cologne"

---

^{astropy/coordinates/angles.py, line 147 [r5] (raw file):}
Clearly you meant to to fix this too.

---

[davidschreiber]

Review status: all files reviewed at latest revision, 33 unresolved discussions, all commit checks successful.

---

^{astropy/coordinates/angle_utilities.py, line 12 [r5] (raw file):}
It would be way better to use bind this module to some custom name, e.g. using import os as customName

---

^{astropy/coordinates/angle_utilities.py, line 152 [r5] (raw file):}
While I understand the need of a simple COLON here, I'd recommend we should refactor this to use a COLONY and some COLONISTS instead. This will prevent future COLONELS with cheap COLOGNEs to add wrong COLORS.

---

Comments from the review on Reviewable.io

[daiqiaobing]

测试完成

[muyehub]

123

[staycolorful]

11111

[Claire-Ahn]

good

[ghost]

make it consistent, UINT is all uppercase

[ajamzad]

Just Checking the product.

[hubblehox]

make it consistent, UINT is all uppercase