feat: switch accrual to e18 fixed-point for tighter rounding#497
Open
ayo-ola0710 wants to merge 1 commit into
Open
feat: switch accrual to e18 fixed-point for tighter rounding#497ayo-ola0710 wants to merge 1 commit into
ayo-ola0710 wants to merge 1 commit into
Conversation
|
@ayo-ola0710 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was done
In this implementation, we replaced the previous per-period BPS-based accrual method with an e18 fixed-point accrual index to eliminate cumulative rounding dust. We added an
E18constant for high-precision arithmetic, introduced new storage keys (AccrualIndexE18for per-offering index tracking andLastClaimedAccrualIndexfor per-holder last-claimed index), updateddo_deposit_revenueto calculate and update the accrual index on each revenue deposit, modifiedset_holder_share_internalto set a holder’s last-claimed index to the current accrual index (ensuring they only earn on future deposits), and rewrote theclaimfunction to use the accrual index to calculate total payouts instead of per-period calculations, all while maintaining existing invariants and usingchecked_mul/checked_divfor secure arithmetic.Close #479