refactor: route i128 hot paths through safe_math wrappers#498
Open
ayo-ola0710 wants to merge 1 commit into
Open
refactor: route i128 hot paths through safe_math wrappers#498ayo-ola0710 wants to merge 1 commit into
ayo-ola0710 wants to merge 1 commit into
Conversation
|
@ayo-ola0710 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was done
A new
safe_mathmodule was introduced to centralize overflow-resistant arithmetic via aSafeMathtrait that exposess_add,s_sub,s_mul, ands_divoperations returning aResult<Self, RevoraError>. Using this new module, hot paths in the codebase—specifically thecompute_sharecalculation, supply cap and revenue accrual updates indeposit_revenueandreport_revenue, and thereconcile_audit_summaryaggregation loop—were refactored to replace silentsaturating_*and rawchecked_*patterns with explicit error-handling boundaries. Finally, comprehensive unit tests were added tosafe_math.rs, and the strict#![deny(clippy::arithmetic_side_effects)]lint was enforced across all touched files (lib.rs,security_assertions.rs, andsafe_math.rs) to guarantee future arithmetic safety.Close #484