feat: defer revenue reports until atomic close_period flush#507
Open
dev-RAM11 wants to merge 1 commit into
Open
feat: defer revenue reports until atomic close_period flush#507dev-RAM11 wants to merge 1 commit into
dev-RAM11 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #456
Description
This PR implements the deferred distribution lifecycle. It ensures that revenue reports can be queued using the
defer_until_closeflag, preventing immediate individual claims until an atomicclose_periodflush occurs. This ensures all holders see the exact same cutover instant.Key Implementations
DeferredReportsstorage map keyed byperiod_id.DistributionDeferrederror.claim()strictly panics if the requested period is still residing in the deferred queue.replace_deferredto allow amount updates on pending reports before the period cutover.close_periodsafely clears the deferred queue and makes the funds globally claimable at the exact same ledger sequence.test_close_period.rsto validate the panic routing.masterbranch is currently failing to compile. There are ~295 workspace errors related to an incompleteDataKey->DataKey2refactor and missingPauseStatedefinitions in the global implementation.My isolated deferred distribution logic, however, is complete and ready for review once the
masterbranch compiles again!