Feat/storage walker upgrade#510
Open
dev-RAM11 wants to merge 4 commits into
Open
Conversation
- Add mod test_time_windows to lib.rs so tests are compiled and run - Move set_report_window, set_claim_window, get_report_window, get_claim_window, and claim into contractimpl block - Fix test_time_windows.rs compatibility issues - All 41 boundary matrix tests passing Closes RevoraOrg#374
test: cover report window inclusive boundaries and zero-width slot
|
@dev-RAM11 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #467
Description
This PR introduces a secure, authenticated
migrate_storage(from_version, to_version)path to handle explicit storage layout upgrades without relying on an implicit background walker.The implementation respects Soroban's state management paradigms by acting as an explicitly triggered, version-aware dispatch table that rewrites legacy keys to new formats.
Changes Made
src/lib.rs:migrate_storagetightly gated byissuer.require_auth().LastMigrationCompletedAtdata key.(from, to)version migrations.mig_stepevent upon successful iteration for off-chain indexer auditing.src/test_storage_layout_version.rs:MigrationAlreadyAppliedfires if an issuer attempts a replay.Security & Execution Notes
LastMigrationCompletedAtstate is permanently persisted after a successful run, mathematically blocking a second invocation of the same migration path.RevoraRevenueSharestruct to avoid scoping errors.Acceptance Criteria Met
migrate_storage(from, to)gated by issuer authentication.last_migration_completed_atto block replays.mig_stepevent emissions.MigrationAlreadyApplied).