Skip to content

docs: clarify pull request CI progress - #5

Open
RidhaOracle wants to merge 4 commits into
trunkfrom
codex/ci-pipeline-smoke-fresh
Open

docs: clarify pull request CI progress#5
RidhaOracle wants to merge 4 commits into
trunkfrom
codex/ci-pipeline-smoke-fresh

Conversation

@RidhaOracle

Copy link
Copy Markdown
Owner

What does this change do?

Clarifies that contributors can use a pull request's Checks tab to follow live CI progress.

Why is it needed?

Provides a small, documentation-only change to exercise the pull-request automation.

How was it tested?

  • Added/updated MTR tests under mysql-test/
  • scripts/ci/mtr.sh passes locally
  • Ran the relevant full suite (name it): ______
  • Verified the Markdown diff with git diff --check

Contributor checklist

  • I have signed the OCA with the email on these commits
  • Code is formatted (documentation-only change)
  • Commits are focused with descriptive messages

AI assistance

  • I used AI assistance for this contribution

Codex made the documentation-only clarification; the patch was reviewed with git diff --check.

Areas touched

Documentation and CI contributor guidance.

harinvadodaria and others added 3 commits July 14, 2026 10:35
Description: Updated CONTRIBUTING.md to include
             code and non-code contributions.
Change-Id: I6a20ca80155434a46203f922d77da25d49186242
Problem:
========
The GitHub contribution path lacked consistent intake templates, shared
local CI entry points, and automated build, test, formatting, ownership,
and triage feedback. Pull requests could also define workflow changes
that executed before those definitions were merged into trunk.
The selected-actions policy prevented the external Codex action from
running.

Solution:
=========
Add structured issue and pull request templates, CODEOWNERS-based review
routing, path-based area labels, and an expanded contributor guide while
preserving the existing non-code contribution terms.

Add scripts/ci helpers for Ubuntu toolchain setup, Ninja and ccache
builds, clang-format, and the default MTR test selection.

Run automatic PR automation from trunk with pull_request_target.
Verify PR merge parents, disable persisted checkout credentials,
scope permissions per job, restore caches without saving PR-controlled
data, and execute build and MTR helpers from the trusted base SHA.

Build Debug configurations with GCC and Clang, run default MTR with
six-hour limits, publish statuses on the PR head, assign code owners
after OCA verification, reconcile approved PRs daily, and apply PR-only
stale handling.

Change-Id: I75d87674e369b28a7ac6707ebb796e0d2a8bcd83
@github-actions github-actions Bot added the Docs Changes touching documentation label Jul 14, 2026
@github-actions

Copy link
Copy Markdown

1. Change summary

Updates CONTRIBUTING.md to tell contributors they can monitor live CI progress through a pull request’s Checks tab.

2. Review findings

No high-confidence, actionable findings.

3. Test gaps or risks

Documentation-only change with minimal risk. No functional tests are necessary; Markdown rendering should be verified in the repository host’s preview.

@github-actions

Copy link
Copy Markdown

1. Change summary

  • Adds guidance to CONTRIBUTING.md for following CI progress through a pull request’s Checks tab.
  • Rewords an allocation-growth comment in mysys/my_alloc.cc.

2. Review findings

  • mysys/my_alloc.cc:102 — The revised comment is imprecise.
    “For the next allocation” suggests m_block_size applies to the next individual allocation, which may instead be served from the current block. The increased size applies when the next block is allocated. Change the wording to “Grow the default block size by 50% for the next block allocation,” or revert this unrelated edit. The PR description should also stop calling the patch documentation-only if this source-file change remains.

3. Test gaps or risks

  • No functional behavior changed, so code or MTR coverage is not required.
  • The main risk is misleading source commentary and the mismatch between the stated documentation-only scope and the actual files changed.

@github-actions github-actions Bot added Build Passed PR build passed MTR Failed MTR suite failed labels Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build Passed PR build passed Docs Changes touching documentation MTR Failed MTR suite failed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants