Skip to content

add carrier integration based on infinitive project#10

Open
jgordon165 wants to merge 2 commits intoRiebart:masterfrom
jgordon165:feature/carrierIntegration
Open

add carrier integration based on infinitive project#10
jgordon165 wants to merge 2 commits intoRiebart:masterfrom
jgordon165:feature/carrierIntegration

Conversation

@jgordon165
Copy link
Copy Markdown

Provide carrier support based upon the infinitive project

https://github.com/acd/infinitive

@Riebart
Copy link
Copy Markdown
Owner

Riebart commented Nov 4, 2020

This looks like it could either be a related repo/project, or it could live in a contrib portion of this library (since those that don't use a Carrier system would have no use for this, and this code doesn't directly touch any of the Vivint logic).

Thoughts?

@jgordon165
Copy link
Copy Markdown
Author

how would you represent the "contrib" portion? Like another folder?

@Riebart
Copy link
Copy Markdown
Owner

Riebart commented Nov 4, 2020

how would you represent the "contrib" portion? Like another folder?

Yeah. Rearrange this into a proper Python module, and the Carrier stuff would life in vivint.contrib.carrier or similar, while the the main stuff would remain as vivint.PanelRoot. This has the benefit of giving semi-related stuff a nice home inside the project.

@jgordonpds
Copy link
Copy Markdown

good idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants