implementation of getNearSolution#1
Draft
iiroak wants to merge 1 commit into
Draft
Conversation
Good library, I was using it to generate a map in MTA:SA but I didn't know how to obtain the solution of this map, I think this could help the library. It will return the closest route to the maze.
Owner
|
Hi, thanks for the PR! There's a couple things I'd like to point out:
Since you're implementing this function as a method of the Maze class, it'd be more efficient to use the internal Cell objects directly instead of first converting to the simple representation. By using the internal Cell objects, you'll be able to easily query all connected cells in a dimension-agnostic way, which fixes the first two issues. Additionally, the Maze class has a few methods you might find useful for validifying user input. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good library, I was using it to generate a map in MTA:SA but I didn't know how to obtain the solution of this map, I think this could help the library. It will return the closest route to the maze.