Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

484: Add warning about Psalm baseline to readme + functional test #489

Open
wants to merge 11 commits into
base: 1.35.x
Choose a base branch
from

Conversation

bdsl
Copy link

@bdsl bdsl commented Dec 2, 2023

See issue #484

@bdsl bdsl changed the title 484: Add warning about Psalm baseline to readme 484: Add warning about Psalm baseline to readme + functional test Dec 2, 2023
.gitignore Outdated Show resolved Hide resolved
test/asset/ProjectWithPsalmBaseline/infection.html Outdated Show resolved Hide resolved
@Ocramius Ocramius force-pushed the 484-baseline-misleading-results branch from 8e8dff8 to ea6ce9c Compare February 8, 2024 16:12
@Ocramius Ocramius self-assigned this Feb 8, 2024
@Ocramius Ocramius added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 8, 2024
@Ocramius Ocramius added this to the 1.35.0 milestone Feb 8, 2024
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This went totally under my radar - now rebased and merging ASAP

@Ocramius Ocramius force-pushed the 484-baseline-misleading-results branch from 8c06296 to 87842c8 Compare February 8, 2024 16:49
@Ocramius
Copy link
Member

Ocramius commented Feb 8, 2024

Oooof, XDebug missing is a pain here, and blocks merge :S

@Ocramius
Copy link
Member

Ocramius commented Feb 8, 2024

Very confused why this fails without any dependency checks, while the mainline build is fine

Why would it be different, since composer.lock didn't change? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants